Merge lp:~wallyworld/launchpad/inline-recipe-distro-series-edit into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Aaron Bentley | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12646 | ||||
Proposed branch: | lp:~wallyworld/launchpad/inline-recipe-distro-series-edit | ||||
Merge into: | lp:launchpad | ||||
Prerequisite: | lp:~wallyworld/launchpad/inline-multicheckbox-widget | ||||
Diff against target: |
625 lines (+207/-76) 11 files modified
lib/lp/app/doc/lazr-js-widgets.txt (+5/-8) lib/lp/code/browser/sourcepackagerecipe.py (+70/-23) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+8/-8) lib/lp/code/configure.zcml (+4/-0) lib/lp/code/interfaces/sourcepackagerecipe.py (+37/-24) lib/lp/code/javascript/requestbuild_overlay.js (+2/-2) lib/lp/code/model/sourcepackagerecipe.py (+6/-0) lib/lp/code/templates/sourcepackagerecipe-index.pt (+2/-9) lib/lp/code/templates/sourcepackagerecipe-new.pt (+1/-1) lib/lp/code/templates/sourcepackagerecipe-request-builds.pt (+1/-1) lib/lp/code/windmill/tests/test_recipe_inline_distroseries_edit.py (+71/-0) |
||||
To merge this branch: | bzr merge lp:~wallyworld/launchpad/inline-recipe-distro-series-edit | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email: mp+52940@code.launchpad.net |
Commit message
[r=abentley][bug=735899] Use the new inline multicheckbox selection widget to edit the source package recipe distroseries attribute.
Description of the change
Use the new inline multicheckbox selection widget to edit the source package recipe distroseries attribute.
== Implementation ==
Not much to tell - just wire up the new widget. Also incorporate Tim's recent changes to the lazr widget infrastructure.
To make everything glue together, the "distros" attribute of the SourcePackageRe
== Demo and QA ==
A screenshot of the widget in action:
http://
== Tests ==
New windmill test added.
/lp/code/
bin/test -vvt test_inline_
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
110: Line exceeds 78 characters.
148: Line exceeds 78 characters.
180: Line exceeds 78 characters.
This looks pretty good.
I wonder whether label_tag="dt" and items_tag="dd" could be defaults.
Sorry for using distros rather than distroseries. I was new to the problem domain.
I don't think you should have a setUp in RecipeEdit until have more than one test, because until you have more tests, you won't know what needs to vary.
I also see you setting up far more constants than you actually use, e.g. recipe name. Why not just use makeSourcePacka geRecipe? (you could use "with person_ logged_ in(recipe. owner)" .
The implementation of updateSeries is a bit sad. Is there no straightforward way to update that?