Merge lp:~wallyworld/launchpad/inline-picker-underscore-1005324 into lp:launchpad

[Ian Booth]

Adjust css so that hovering over picker activation icon doesn't show an underscore.

The picker activation icons were showing an underscore when hovered over. This was because a   had been added in various places to ensure the sprite icons show, since in some browsers the icons are not rendered if the anchor tag is empty.

== Implementation ==

I added css to suppress the underscore for any links the are marked as sprites.

I also fixed the issue in Opera where by the inline text editor activation icon had a funny Unicode char next to it. It turns out this was an attempt in the old lazr js library to get around the icon rendering issue for empty anchors. I replaced the Unicode char used with a   like what is used everywhere else.

== QA ==

I tested in Opera, Chrome, Firefox, Konquerer.

Konquerer did not show icons for *anything* - not menu portal links, not person links, nothing. So the work in this branch fixes everything for all other browsers but Konquerer still has issues all over the place, not just in the areas covered by this branch. I'm not sure what its problem is.

[Curtis Hovey (sinzui)]

Hi Ian.

I need to think about this. Your CSS change removed the underlines from menu links, it is not clear that text with icons are links. I do not want to solve the issue this way. We really want to remove the false content.

Konqueror is broken by bug 521219; the sprite image is physically too tall to render. I think we want to test which browsers require content in the sprite. We know this affected khtml and older webkits. Maybe we can use YUI to add a CSS class to the body element. when only activates the CSS rule you deleted See http://developer.yahoo.com/yui/3/api/UA.html#property_webkit
    Y.UA.webkit === 1

review: Needs Fixing (code)

[Curtis Hovey (sinzui)]

I think I have this content hack isolated to a specific range of webkit that allows us to remove the nbsp hacks from a lot of templates.

This is the script that must be executed on every page to identify the problem engine:
    if (Y.UA.Webkit > 0 Y.UA.webkit < 533) {
        Y.one('body').addClass('old-webkit');
    }

This is the CSS rule that added a the nbsp to old-webkit
    body.old-webkit .sprite {
        content: "\00A0";
        }

We then delete about 40 &nbsp; we inserted into anchors in pt, js, and py

[Ian Booth (wallyworld)]

I have added the required css and webkit version check to set the body style.

I have removed some nbsp from anchors with "spite edit" classes. However, anchors which exist to provide popup help still require the nbsp to be used for reasons I don't understand.

eg from bugtask-index.pt

<a href="/+help-bugs/tag-help.html" target="help" class="sprite maybe">
  &nbsp;
  <span class="invisible-link">Tag help</span>
</a>

If I remove the nbsp, the 'maybe' sprite does not render. I do not know why. I guess if we figure out what to do the nbsp can be removed in a subsequent branch.

[Ian Booth (wallyworld)]

I should say the help icon issue in the above comment only occurs in Chrome, not Firefox.

[Curtis Hovey (sinzui)]

I am going to merge an look into this help issue. My local test on chromium does not show this. In fact, the markup you show has leading and trailing white-space that do take up space.

[Curtis Hovey (sinzui)]

I've sussed it! The space is collapsed when white-space is processed is normalised. This works:

This fails because there is white-space after the open tag and before the close tag that needs normalisation:
    <a href="/+help-bugs/tag-help.html" target="help" class="sprite maybe">
    <span class="invisible-link">Tag help</span>
    </a>

This works:
    <a href="/+help-bugs/tag-help.html" target="help" class="sprite maybe"><span class="invisible-link">Tag help</span></a>

As does this:
    <a href="/+help-bugs/tag-help.html" target="help" class="sprite maybe"
      ><span class="invisible-link">Tag help</span></a>

The anchor you are working with does not conform to Lp style. We know that browsers do not handle white-space normalisation consistently...webkit is closest to the standard because leading and trailing spaces are supposed to be stripped. Yet this phase causes reallocation of space that ignore the padding rule :(

[Curtis Hovey (sinzui)]

Hi Ian.

I think I have found most of the lines that need investigation and updating. As above, the rule is to ensure there are no spaces in the anchor tag.

./lib/lp/app/templates/inline-picker.pt
      18: class="sprite maybe">&nbsp;
./lib/lp/app/browser/tales.py
     886: '<span class="sprite %(icon)s">&nbsp;'
     912: '<a href="%s" alt="%s" title="%s" class="%s">&nbsp;</a>')
./lib/lp/app/doc/tales.txt
     215: <span class="sprite no">&nbsp;<span
     219: <span class="sprite no">&nbsp;<span
     223: <span class="sprite yes">&nbsp;<span
     227: <span class="sprite yes">&nbsp;<span
./lib/lp/app/javascript/choice.js
      65: '<a href="#"><img class="sprite edit editicon"/>&nbsp;</a></span>'
./lib/lp/app/javascript/formwidgets/formwidgets.js
     121: 'target="help" class="sprite maybe">&nbsp;' +
./lib/lp/registry/templates/person-upcomingwork.pt
      92: <a href="#" class="expander">&nbsp;</a>
./lib/lp/bugs/javascript/bugtask_index.js
     125: '<span class="invisible-link">edit</span>&nbsp;</a>');
./lib/lp/bugs/templates/bugtasks-and-nominations-portal.pt
      78: class="sprite maybe">&nbsp;
./lib/lp/bugs/templates/bugtask-choose-affected-product.pt
      23: class="sprite maybe">&nbsp;<span class="invisible-link">(?)</span>
./lib/lp/bugs/templates/bugtask-index.pt
     169: <a href="/+help-bugs/tag-help.html" target="help" class="sprite maybe">&nbsp;
./lib/lp/bugs/templates/bugcomment-macros.pt
      60: <span class="sprite arrowRight">&nbsp;</span>
./lib/lp/bugs/stories/bugtask-searches/xx-listing-basics.txt
     229: title="Linked to milestone 3.1" class="sprite milestone">&nbsp;</a>
./lib/lp/registry/templates/person-macros.pt
      68: target="help">&nbsp;</a>
./lib/lp/registry/templates/person-portlet-contact-details.pt
      75: <a target="help" href="/+help-registry/openid.html" class="sprite maybe">&nbsp;
     186: <a target="help" href="/+help-registry/karma.html" class="sprite maybe">&nbsp;
./lib/lp/registry/templates/distroseries-initialize.pt
      20: target="help" class="sprite maybe">&nbsp;
./lib/lp/registry/javascript/sharing/shareetable.js
     162: ' data-person_name="{{display_name}}">&nbsp;</a>',
     168: ' data-person_name="{{display_name}}">&nbsp;</a>',
     205: ' <a class="editicon sprite edit" href="#">&nbsp;</a>',
./lib/lp/registry/javascript/sharing/sharingdetails.js
     284: ' <span class="sprite bug-{{bug_importance}}">&nbsp;</span>',
     296: ' &nbsp;</a>',
     323: ' &nbsp;</a>',
./lib/lp/blueprints/templates/specification-index.pt
     287: <a href="/+help-blueprints/workitems-help.html" target="help" class="sprite maybe">&nbsp;
./lib/lp/app/templates/launchpad-form.pt
     110: &nbsp;<span class="invisible-link">(?)</span>
     132: &nbsp;<span class="invisible-link">(?)</span>
     152: &nbsp;<span class="invisible-link">(?)</span>
./lib/lp/code/templates/branch-recipes.pt
      24: &nbsp;<span class="invisible-link">Tag help</span>
./lib/lp/code/templates/sourcepackagerecipe-index.pt
      87: &nbsp;<span class="invisible-link">Tag help</span>
./lib/lp/registry/templates/distroseries-add.pt
      15: &nbsp;<span class="invisible-link">(?)</span>
./lib/lp/registry/t...

[Curtis Hovey (sinzui)]

BTW, Since I think we now understand the issue, the remaining changes are trivial. I am approving this.

review: Approve (code)

[Ian Booth (wallyworld)]

I have found and fixed another problem that appears in Chrome. The issue still causes the anchor icon not be be rendered but appears (to me) to have a lightly different root cause. And it affects lp in production right now swo has been a long standing issue in Chrome AFAICT.

The milestone index page as some text "Yes. Drivers can target bugs and blueprints to this milestone." which is supposed to have an Edit icon next to it. The edit icon is not rendered. The TAL is:

      <dd>
        <tal:yes condition="context/active">
          Yes. Drivers can target bugs and blueprints to this milestone.
        </tal:yes>
        <tal:no condition="not: context/active">
          No. Drivers cannot target bugs and blueprints to this milestone.
        </tal:no>
        &nbsp; <a tal:replace="structure milestone_menu/edit/fmt:icon" />
      </dd>

The issue turned out to be the extra ' ' between the &nbsp; and the "<a..."
The &nbsp; is used to separate the icon a little from the text it is next too. But the extra ' ' caused the icon not to render. I am not sure why.

=== modified file 'lib/canonical/launchpad/icing/css/typography.css'
--- lib/canonical/launchpad/icing/css/typography.css	2012-03-10 15:33:33 +0000
+++ lib/canonical/launchpad/icing/css/typography.css	2012-05-31 07:22:20 +0000
@@ -87,6 +87,10 @@
     /* No border on images that are links. */
     border: none;
     }
+body.old-webkit .sprite a.expander {
+    /* Old webkit browsers require a nbsp so sprites render. */
+    content: "\00A0";
+    }
 abbr[title], acronym[title] {
     border-bottom: 1px dotted black;
     cursor: help;

=== modified file 'lib/lp/app/browser/tales.py'
--- lib/lp/app/browser/tales.py	2012-05-18 22:04:13 +0000
+++ lib/lp/app/browser/tales.py	2012-05-31 07:22:20 +0000
@@ -672,7 +672,6 @@
             css_classes.add('global-notification-visible')
         return ' '.join(list(css_classes))
 
-
     def _getSaneBreadcrumbDetail(self, breadcrumb):
         text = breadcrumb.detail
         if len(text) > 64:
@@ -883,7 +882,7 @@
         else:
             icon = 'no'
         markup = (
-            '<span class="sprite %(icon)s">&nbsp;'
+            '<span class="sprite %(icon)s">'
             '<span class="invisible-link">%(icon)s</span></span>')
         return markup % dict(icon=icon)
 
@@ -906,10 +905,10 @@
         ])
 
     icon_template = (
-        '<span alt="%s" title="%s" class="%s">&nbsp;</span>')
+        '<span alt="%s" title="%s" class="%s"></span>')
 
     linked_icon_template = (
-        '<a href="%s" alt="%s" title="%s" class="%s">&nbsp;</a>')
+        '<a href="%s" alt="%s" title="%s" class="%s"></a>')
 
     def traverse(self, name, furtherPath):
         """Special-case traversal for icons with an optional rootsite."""

=== modified file 'lib/lp/app/doc/lazr-js-widgets.txt'
--- lib/lp/app/doc/lazr-js-widgets.txt	2012-05-12 12:32:21 +0000
+++ lib/lp/app/doc/lazr-js-widgets.txt	2012-05-31 07:22:20 +0000
@@ -266,7 +266,7 @@
       <span>
         <a class="sprite edit lazr-btn yui3-activator-act"
           href="http://launchpad.dev/widget/+edit"
-          title="">&nbsp;<span class="invisible-link">Edit</span></a>
+          title=""><span class="invisible-link">Edit</span></a>
         <div class="yui3-activator-message-box yui3-activator-hidden"></div>
     </span> ...
 
@@ -473,7 +473,7 @@
           <a class="sprite edit lazr-btn yui3-activator-act"
              href="http://code.launchpad.dev/~eric/+recipe/cake_recipe/+edit"
              id="edit-distroseries-btn"
-             title="">&nbsp;<span class="invisible-link">Edit</span></a>
+             title=""><span class="invisible-link">Edit</span></a>
       </dt>
       <span class="yui3-activator-data-box">
         <dl id='edit-distroseries-items'>

=== modified file 'lib/lp/app/doc/tales.txt'
--- lib/lp/app/doc/tales.txt	2012-05-22 17:00:08 +0000
+++ lib/lp/app/doc/tales.txt	2012-05-31 07:22:20 +0000
@@ -212,19 +212,19 @@
 All objects can be represented as a boolean icon.
 
     >>> print test_tales("context/image:boolean", context=None)
-    <span class="sprite no">&nbsp;<span
+    <span class="sprite no"><span
       class="invisible-link">no</span></span>
 
     >>> print test_tales("context/image:boolean", context=False)
-    <span class="sprite no">&nbsp;<span
+    <span class="sprite no"><span
       class="invisible-link">no</span></span>
 
     >>> print test_tales("context/image:boolean", context=object())
-    <span class="sprite yes">&nbsp;<span
+    <span class="sprite yes"><span
       class="invisible-link">yes</span></span>
 
     >>> print test_tales("context/image:boolean", context=True)
-    <span class="sprite yes">&nbsp;<span
+    <span class="sprite yes"><span
       class="invisible-link">yes</span></span>
 
 

=== modified file 'lib/lp/app/javascript/formwidgets/formwidgets.js'
--- lib/lp/app/javascript/formwidgets/formwidgets.js	2011-11-08 16:35:11 +0000
+++ lib/lp/app/javascript/formwidgets/formwidgets.js	2012-05-31 07:22:20 +0000
@@ -118,7 +118,7 @@
         this.labelNode = Y.Node.create("<label />");
         this.helpNode = Y.Node.create(('<span class="helper unseen">'+
             '&nbsp;<a href=""' +
-            'target="help" class="sprite maybe">&nbsp;' +
+            'target="help" class="sprite maybe">' +
             '<span class="invisible-link"></span></a></span>'));
         this.fieldNode = Y.Node.create("<div></div>");
         this.descriptionNode = Y.Node.create('<p class="formHelp" />');

=== modified file 'lib/lp/app/javascript/inlineedit/assets/editor-core.css'
--- lib/lp/app/javascript/inlineedit/assets/editor-core.css	2011-12-21 07:54:40 +0000
+++ lib/lp/app/javascript/inlineedit/assets/editor-core.css	2012-05-31 07:22:20 +0000
@@ -22,24 +22,3 @@
 .yui3-ieditor-input textarea:focus {
     outline: none;
 }
-
-/* Konqueror doesn't render the multiline editor's button if there's
- * no apparent content in it (the sprite we use is a background image).
- * This bit of CSS is meaningless; it sets the edit link's content to
- * a zero-width non-joiner (an invisible, odorless Unicode character).
- *
- * Browsers should ignore the content attribute for :link and :visited
- * pseudo-classes, but Konqueror doesn't.  Setting non-empty text
- * content here tricks it into rendering the button.
- *
- * Other things we tried instead of this hack:
- *  - Insert an HTML comment in the <a>.  No effect.
- *  - Insert a &nbsp; in the <a>.  No effect.
- *  - Insert whitespace in the <a>.  No effect.
- *  - Insert a span or div in the <a>.  No effect.
- *  - Use a regular <img> tag instead of a sprite.  Ugly in all browsers.
- *  - Set the content to ".".  Ugly in Konqueror.
- */
-.yui3-editable_text-trigger:link, .yui3-editable_text-trigger:visited {
-    content: "\200c";
-}

=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2012-05-15 17:17:34 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2012-05-31 07:22:20 +0000
@@ -151,6 +151,7 @@
   <metal:load-lavascript use-macro="context/@@+base-layout-macros/load-javascript" />
 
     <script id="base-layout-load-scripts" type="text/javascript">
+        //<![CDATA[
         LPJS.use('base', 'node', 'console', 'event',
             'oop', 'lp', 'lp.app.banner.privacy',
             'lp.app.banner.beta', 'lp.app.foldables','lp.app.sorttable',
@@ -164,6 +165,9 @@
                     banner = Y.lp.app.banner.privacy.getPrivacyBanner();
                     banner.show();
                 }
+                if (Y.UA.webkit > 0 && Y.UA.webkit < 533) {
+                    Y.one(document.body).addClass('old-webkit');
+                }
                 Y.lp.app.banner.beta.show_beta_if_needed();
                 Y.lp.app.sorttable.SortTable.init();
                 Y.lp.app.inlinehelp.init_help();
@@ -184,6 +188,7 @@
                   window.location = e.new_value;
             });
         });
+        //]]>
     </script>
     <script id="base-helper-functions" type="text/javascript">
          //<![CDATA[

=== modified file 'lib/lp/app/templates/inline-multicheckbox-widget.pt'
--- lib/lp/app/templates/inline-multicheckbox-widget.pt	2012-05-12 03:19:06 +0000
+++ lib/lp/app/templates/inline-multicheckbox-widget.pt	2012-05-31 07:22:20 +0000
@@ -11,7 +11,7 @@
                          href view/edit_url;
                          title view/edit_title"
          class="sprite edit lazr-btn yui3-activator-act"
-         >&nbsp;<span class="invisible-link">Edit</span></a>
+         ><span class="invisible-link">Edit</span></a>
     </tal:has_choices>
   <tal:label-close-tag replace="structure view/label_close_tag"/>
   <span class="yui3-activator-data-box">

=== modified file 'lib/lp/app/templates/inline-picker.pt'
--- lib/lp/app/templates/inline-picker.pt	2012-04-25 18:17:08 +0000
+++ lib/lp/app/templates/inline-picker.pt	2012-05-31 07:22:20 +0000
@@ -10,14 +10,12 @@
       <a tal:attributes="href view/edit_url;
                          title view/edit_title"
          class="sprite edit lazr-btn yui3-activator-act"
-         >&nbsp;<span class="invisible-link">Edit</span></a>
+         ><span class="invisible-link">Edit</span></a>
 
       <a tal:condition="view/help_link"
          tal:attributes="href view/help_link"
          target="help"
-         class="sprite maybe">&nbsp;
-         <span class="invisible-link">Driver help</span>
-      </a>
+         class="sprite maybe"><span class="invisible-link">Driver help</span></a>
       <div class="yui3-activator-message-box yui3-activator-hidden"></div>
     </span>
   </span>

=== modified file 'lib/lp/app/templates/launchpad-form.pt'
--- lib/lp/app/templates/launchpad-form.pt	2011-12-15 22:00:24 +0000
+++ lib/lp/app/templates/launchpad-form.pt	2012-05-31 07:22:20 +0000
@@ -106,9 +106,8 @@
         <input tal:replace="structure widget" />
         <tal:help-link condition="widget_help_link">
           <a tal:attributes="href widget_help_link"
-             target="help" class="sprite maybe">
-            &nbsp;<span class="invisible-link">(?)</span>
-          </a>
+             target="help"
+             class="sprite maybe"><span class="invisible-link">(?)</span></a>
         </tal:help-link>
       </div>
       <div class="message" tal:condition="error"
@@ -128,9 +127,8 @@
       </tal:label>
       <tal:help-link condition="widget_help_link">
         <a tal:attributes="href widget_help_link"
-           target="help" class="sprite maybe">
-          &nbsp;<span class="invisible-link">(?)</span>
-        </a>
+           target="help"
+           class="sprite maybe"><span class="invisible-link">(?)</span></a>
       </tal:help-link>
       <div tal:condition="error" tal:content="structure error"
            class="message">Error message</div>
@@ -148,9 +146,8 @@
              tal:content="widget/label">Label</label>
       <tal:help-link condition="widget_help_link">
         <a tal:attributes="href widget_help_link"
-           target="help" class="sprite maybe">
-          &nbsp;<span class="invisible-link">(?)</span>
-        </a>
+           target="help"
+           class="sprite maybe"><span class="invisible-link">(?)</span></a>
       </tal:help-link>
       <div tal:condition="error" tal:content="structure error"
            class="message">Error message</div>

=== modified file 'lib/lp/app/templates/launchpad-inline-icon-link.pt'
--- lib/lp/app/templates/launchpad-inline-icon-link.pt	2011-05-27 18:01:09 +0000
+++ lib/lp/app/templates/launchpad-inline-icon-link.pt	2012-05-31 07:22:20 +0000
@@ -5,5 +5,5 @@
   tal:attributes="
     class string:menu-link-${context/name} sprite ${context/icon};
     href context/url;
-    title context/summary;"
-><span class="invisible-link" tal:content="context/text"></span></a></tal:link-enabled>
+    title context/summary;"><span class="invisible-link"
+              tal:content="context/text"></span></a></tal:link-enabled>

=== modified file 'lib/lp/blueprints/templates/specification-index.pt'
--- lib/lp/blueprints/templates/specification-index.pt	2012-03-05 13:04:16 +0000
+++ lib/lp/blueprints/templates/specification-index.pt	2012-05-31 07:22:20 +0000
@@ -284,8 +284,8 @@
     </div>
 
     <div class="portlet">
-      <a href="/+help-blueprints/workitems-help.html" target="help" class="sprite maybe">&nbsp;
-        <span class="invisible-link">Tag help</span></a>
+      <a href="/+help-blueprints/workitems-help.html" target="help"
+         class="sprite maybe"><span class="invisible-link">Tag help</span></a>
       <div class="wide" tal:content="structure view/workitems_text_widget" />
     </div>
 

=== modified file 'lib/lp/bugs/browser/tests/test_bugtask.py'
--- lib/lp/bugs/browser/tests/test_bugtask.py	2012-05-30 21:54:41 +0000
+++ lib/lp/bugs/browser/tests/test_bugtask.py	2012-05-31 07:22:20 +0000
@@ -2436,7 +2436,7 @@
             self.assertEqual(item.bug_heat_html, model['bug_heat_html'])
             self.assertEqual(
                 '<span alt="private" title="Private" class="sprite private">'
-                '&nbsp;</span>', model['badges'])
+                '</span>', model['badges'])
             self.assertEqual(None, model['milestone_name'])
             item.bugtask.milestone = self.factory.makeMilestone(
                 product=item.bugtask.target)

=== modified file 'lib/lp/bugs/javascript/bugtask_index.js'
--- lib/lp/bugs/javascript/bugtask_index.js	2012-05-15 19:10:39 +0000
+++ lib/lp/bugs/javascript/bugtask_index.js	2012-05-31 07:22:20 +0000
@@ -122,7 +122,7 @@
             var privacy_text = Y.one('#privacy-text');
             privacy_link = Y.Node.create(
                 '<a id="privacy-link" class="sprite edit" title="[edit]">' +
-                '<span class="invisible-link">edit</span>&nbsp;</a>');
+                '<span class="invisible-link">edit</span></a>');
             privacy_link.set('href', privacy_link_url);
             privacy_text.appendChild(privacy_link);
             privacy_spinner = Y.Node.create(
@@ -422,7 +422,7 @@
                     privacy_div.replaceClass('private', 'public');
                     privacy_text.set(
                         'innerHTML', 'This report is public ');
-                   banner.hide(); 
+                    banner.hide();
                 }
                 privacy_text.appendChild(privacy_link);
                 privacy_text.appendChild(privacy_spinner);
@@ -1514,4 +1514,5 @@
                         "lp.bugs.information_type_choice",
                         "lp.app.widgets.expander", "lp.client", "escape",
                         "lp.client.plugins", "lp.app.errors",
-                        "lp.app.banner.privacy", "lp.app.confirmationoverlay"]});
+                        "lp.app.banner.privacy",
+                        "lp.app.confirmationoverlay"]});

=== modified file 'lib/lp/bugs/stories/bugtask-searches/xx-listing-basics.txt'
--- lib/lp/bugs/stories/bugtask-searches/xx-listing-basics.txt	2012-02-08 12:12:34 +0000
+++ lib/lp/bugs/stories/bugtask-searches/xx-listing-basics.txt	2012-05-31 07:22:20 +0000
@@ -226,7 +226,7 @@
     >>> milestone = find_tags_by_class(browser.contents, 'sprite milestone')
     >>> print milestone[0]
     <a href="http://launchpad.dev/debian/+milestone/3.1" alt="milestone 3.1"
-    title="Linked to milestone 3.1" class="sprite milestone">&nbsp;</a>
+    title="Linked to milestone 3.1" class="sprite milestone"></a>
 
 
 Patches also appear as badges in bug listings.

=== modified file 'lib/lp/bugs/templates/bugcomment-macros.pt'
--- lib/lp/bugs/templates/bugcomment-macros.pt	2012-05-11 21:10:07 +0000
+++ lib/lp/bugs/templates/bugcomment-macros.pt	2012-05-31 07:22:20 +0000
@@ -57,7 +57,7 @@
         <tbody>
           <tr>
             <td>
-              <span class="sprite arrowRight">&nbsp;</span>
+              <span class="sprite arrowRight"></span>
               <span tal:replace="num_hidden">42</span> comments hidden
               <span id="more-comments-spinner" class="hidden">
                 Loading more comments

=== modified file 'lib/lp/bugs/templates/bugtask-choose-affected-product.pt'
--- lib/lp/bugs/templates/bugtask-choose-affected-product.pt	2011-11-26 04:03:29 +0000
+++ lib/lp/bugs/templates/bugtask-choose-affected-product.pt	2012-05-31 07:22:20 +0000
@@ -20,8 +20,7 @@
         A bug may need fixing in more than one project. You may add another
         project for this bug here. 
         <a href="/+help-bugs/also-affects-project-help.html" target="help" 
-        class="sprite maybe">&nbsp;<span class="invisible-link">(?)</span>
-        </a>
+        class="sprite maybe"><span class="invisible-link">(?)</span></a>
     </p>
 
     <p tal:content="structure context/fmt:link" />

=== modified file 'lib/lp/bugs/templates/bugtask-index.pt'
--- lib/lp/bugs/templates/bugtask-index.pt	2012-05-12 03:19:06 +0000
+++ lib/lp/bugs/templates/bugtask-index.pt	2012-05-31 07:22:20 +0000
@@ -157,8 +157,8 @@
                       id="edit-tags-cancel"
                       type="button">Cancel</button>
            </form>
-           <a href="/+help-bugs/tag-help.html" target="help" class="sprite maybe">&nbsp;
-             <span class="invisible-link">Tag help</span></a>
+           <a href="/+help-bugs/tag-help.html" target="help"
+              class="sprite maybe"><span class="invisible-link">Tag help</span></a>
           </div>
           <div id="add-bug-tags"
                tal:attributes="class python: (not(context.bug.tags) and
@@ -166,8 +166,8 @@
             <a href="+edit" title="Add tags" id="add-tags-trigger" class="sprite add">
               Add tags
             </a>
-            <a href="/+help-bugs/tag-help.html" target="help" class="sprite maybe">&nbsp;
-            <span class="invisible-link">Tag help</span></a>
+            <a href="/+help-bugs/tag-help.html" target="help"
+               class="sprite maybe"><span class="invisible-link">Tag help</span></a>
             <script type="text/javascript">
                 LPJS.use('event', 'node', 'lp.bugs.bug_tags_entry', function(Y) {
                     Y.on('domready',

=== modified file 'lib/lp/bugs/templates/bugtasks-and-nominations-portal.pt'
--- lib/lp/bugs/templates/bugtasks-and-nominations-portal.pt	2012-05-12 03:19:06 +0000
+++ lib/lp/bugs/templates/bugtasks-and-nominations-portal.pt	2012-05-31 07:22:20 +0000
@@ -75,9 +75,7 @@
         replace="structure link/render" />
         <a href="/+help-bugs/also-affects-project-help.html"
            target="help"
-           class="sprite maybe">&nbsp;
-             <span class="invisible-link">(?)</span>
-        </a>
+           class="sprite maybe"><span class="invisible-link">(?)</span></a>
     </span>
     <span id="also-affects-package"
           tal:attributes="class python:not view.canAddPackageTask() and 'private-disallow' or ''"

=== modified file 'lib/lp/code/templates/branch-recipes.pt'
--- lib/lp/code/templates/branch-recipes.pt	2011-11-26 04:03:29 +0000
+++ lib/lp/code/templates/branch-recipes.pt	2012-05-31 07:22:20 +0000
@@ -20,9 +20,8 @@
       </tal:recipes>
       using this branch.
 
-      <a href="/+help-code/related-recipes.html" target="help" class="sprite maybe">
-        &nbsp;<span class="invisible-link">Tag help</span>
-      </a>
+      <a href="/+help-code/related-recipes.html" target="help"
+         class="sprite maybe"><span class="invisible-link">Tag help</span></a>
     </div>
 
     <span

=== modified file 'lib/lp/code/templates/branch-related-bugs-specs.pt'
--- lib/lp/code/templates/branch-related-bugs-specs.pt	2012-05-11 22:11:37 +0000
+++ lib/lp/code/templates/branch-related-bugs-specs.pt	2012-05-31 07:22:20 +0000
@@ -53,7 +53,7 @@
           <tal:link replace="structure spec/fmt:link:blueprints" />
           <tal:show-edit condition="show_edit|nothing">
             <a class="sprite edit"
-              tal:attributes="href spec_branch/fmt:url;">&nbsp;</a>
+              tal:attributes="href spec_branch/fmt:url;"></a>
           </tal:show-edit>
         </li>
 

=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
--- lib/lp/code/templates/sourcepackagerecipe-index.pt	2012-05-11 22:06:46 +0000
+++ lib/lp/code/templates/sourcepackagerecipe-index.pt	2012-05-31 07:22:20 +0000
@@ -83,9 +83,8 @@
         <div class="two-column-list">
           <dl id="build_daily">
             <dt>Build schedule:
-              <a href="/+help-code/recipe-build-frequency.html" target="help" class="sprite maybe">
-                &nbsp;<span class="invisible-link">Tag help</span>
-              </a>
+              <a href="/+help-code/recipe-build-frequency.html" target="help"
+                 class="sprite maybe"><span class="invisible-link">Tag help</span></a>
             </dt>
             <dd tal:content="structure view/daily_build_widget"/>
             <dd

=== modified file 'lib/lp/registry/javascript/sharing/shareetable.js'
--- lib/lp/registry/javascript/sharing/shareetable.js	2012-05-30 11:25:12 +0000
+++ lib/lp/registry/javascript/sharing/shareetable.js	2012-05-31 07:22:20 +0000
@@ -164,13 +164,13 @@
             '    <a title="Stop sharing with {{display_name}}"',
             '       href="#" class="sprite remove"',
             '        data-self_link="{{self_link}}"',
-            '        data-person_name="{{display_name}}">&nbsp;</a>',
+            '        data-person_name="{{display_name}}"></a>',
             '</span>',
             '<span id="update-{{name}}">',
             '    <a title="Update sharing for {{display_name}}"',
             '       href="#" class="sprite add"',
             '        data-self_link="{{self_link}}"',
-            '        data-person_name="{{display_name}}">&nbsp;</a>',
+            '        data-person_name="{{display_name}}"></a>',
             '</span>',
             '</td>',
             '<td id="td-permission-{{name}}">',
@@ -207,7 +207,7 @@
            '<li class="nowrap">',
            '<span id="{{policy}}-permission-{{sharee_name}}">',
            '  <span class="value"></span>',
-           '  <a class="editicon sprite edit" href="#">&nbsp;</a>',
+           '  <a class="editicon sprite edit" href="#"></a>',
            '</span></li>',
            '{{/information_types}}'].join(' ');
     },

=== modified file 'lib/lp/registry/javascript/sharing/sharingdetails.js'
--- lib/lp/registry/javascript/sharing/sharingdetails.js	2012-05-11 06:29:27 +0000
+++ lib/lp/registry/javascript/sharing/sharingdetails.js	2012-05-31 07:22:20 +0000
@@ -281,7 +281,7 @@
         '<tr id="shared-bug-{{ bug_id }}">',
         '    <td class="icon right">',
         '        <span class="sortkey">{{bug_id}}</span>',
-        '        <span class="sprite bug-{{bug_importance}}">&nbsp;</span>',
+        '        <span class="sprite bug-{{bug_importance}}"></span>',
         '    </td>',
         '    <td class="amount">{{bug_id}}</td>',
         '    <td>',
@@ -292,8 +292,7 @@
         '    <a class="sprite remove" href="#"',
         '        title="Unshare bug {{bug_id}} with {{displayname}}"',
         '        data-self_link="{{self_link}}" data-name="Bug {{bug_id}}"',
-        '        data-type="bug">',
-        '    &nbsp;</a>',
+        '        data-type="bug"></a>',
         '    </span>',
         '    </td>',
         '   <td>',
@@ -319,8 +318,7 @@
         '    <a class="sprite remove" href="#"',
         '        title="Unshare branch {{branch_name}} with {{displayname}}"',
         '        data-self_link="{{self_link}}" data-name="{{branch_name}}"',
-        '        data-type="branch">',
-        '    &nbsp;</a>',
+        '        data-type="branch"></a>',
         '    </span>',
         '    </td>',
         '   <td>',

=== modified file 'lib/lp/registry/javascript/structural-subscription.js'
--- lib/lp/registry/javascript/structural-subscription.js	2012-03-21 01:17:13 +0000
+++ lib/lp/registry/javascript/structural-subscription.js	2012-05-31 07:22:20 +0000
@@ -1361,9 +1361,7 @@
             .append(Y.Node.create('<span/>')
                 .addClass('invisible-link')
                 .set('text', 'Delivery help')));
-        // For some reason the help link will not appear in Chrome unless
-        // there is a non-empty element immediately after the help node.
-        control.append(Y.Node.create('<span>&nbsp;</span>'));
+        control.append(Y.Node.create('<span></span>'));
         // We store a reference to the timeout that will hide the help link so
         // we can cancel it if needed.
         var hide_help_timeout;

=== modified file 'lib/lp/registry/templates/distributionsourcepackage-index.pt'
--- lib/lp/registry/templates/distributionsourcepackage-index.pt	2012-03-10 13:48:37 +0000
+++ lib/lp/registry/templates/distributionsourcepackage-index.pt	2012-05-31 07:22:20 +0000
@@ -150,9 +150,7 @@
         <td style="white-space: nowrap">
           <a class="expander"
              tal:attributes="id string:pub${pubid}-expander;
-                             href string:${archive/fmt:url}/+sourcepub/${pubid}/+listing-archive-extra">
-            &nbsp;
-          </a>
+                             href string:${archive/fmt:url}/+sourcepub/${pubid}/+listing-archive-extra"></a>
           <a tal:attributes="href row/version">
             <img src="/@@/package-source" />
             <tal:version content="row/version"/>

=== modified file 'lib/lp/registry/templates/distroseries-add.pt'
--- lib/lp/registry/templates/distroseries-add.pt	2011-11-26 04:03:29 +0000
+++ lib/lp/registry/templates/distroseries-add.pt	2012-05-31 07:22:20 +0000
@@ -11,9 +11,8 @@
         <p metal:fill-slot="extra_info">
           This page allows you to add a new distribution series.
           <a href="/+help-registry/distribution-add-series.html"
-             target="help" class="sprite maybe">
-            &nbsp;<span class="invisible-link">(?)</span>
-          </a>
+             target="help"
+             class="sprite maybe"><span class="invisible-link">(?)</span></a>
         </p>
       </div>
     </div>

=== modified file 'lib/lp/registry/templates/distroseries-initialize.pt'
--- lib/lp/registry/templates/distroseries-initialize.pt	2012-02-01 15:31:32 +0000
+++ lib/lp/registry/templates/distroseries-initialize.pt	2012-05-31 07:22:20 +0000
@@ -16,9 +16,9 @@
       <tal:enabled condition="view/show_derivation_form">
       <div class="top-portlet">
         This page allows you to initialize a distribution series.
-        <a href="/+help-registry/init-series-title-help.html"
-           target="help" class="sprite maybe">&nbsp;
-          <span class="invisible-link">Initialization help</span></a>
+        <a href="/+help-registry/init-series-title-help.html" target="help"
+           class="sprite maybe"><span
+           class="invisible-link">Initialization help</span></a>
       </div>
       <p class="error message javascript-disabled">
         Javascript is required to use this page. Please enable

=== modified file 'lib/lp/registry/templates/milestone-index.pt'
--- lib/lp/registry/templates/milestone-index.pt	2012-02-01 15:31:32 +0000
+++ lib/lp/registry/templates/milestone-index.pt	2012-05-31 07:22:20 +0000
@@ -132,7 +132,7 @@
                 <tal:no condition="not: context/active">
                   No.  Drivers cannot target bugs and blueprints to this milestone.
                 </tal:no>
-                &nbsp; <a tal:replace="structure milestone_menu/edit/fmt:icon" />
+                &nbsp;<a tal:replace="structure milestone_menu/edit/fmt:icon" />
               </dd>
             </dl>
 

=== modified file 'lib/lp/registry/templates/milestone-tag-search.pt'
--- lib/lp/registry/templates/milestone-tag-search.pt	2012-01-02 11:12:46 +0000
+++ lib/lp/registry/templates/milestone-tag-search.pt	2012-05-31 07:22:20 +0000
@@ -24,9 +24,8 @@
     <p>
       <tal:tags replace="structure view/widgets/tags" />
       <input tal:replace="structure view/search_by_tags/render" />
-      <a target="help" href="/+help-registry/milestone-tags.html" class="sprite maybe">
-        &nbsp;<span class="invisible-link">Milestone Tags help</span>
-      </a>
+      <a target="help" href="/+help-registry/milestone-tags.html"
+         class="sprite maybe"><span class="invisible-link">Milestone Tags help</span></a>
     </p>
 
     <div class="error" tal:condition="view/errors">

=== modified file 'lib/lp/registry/templates/person-editpgpkeys.pt'
--- lib/lp/registry/templates/person-editpgpkeys.pt	2012-03-02 16:17:46 +0000
+++ lib/lp/registry/templates/person-editpgpkeys.pt	2012-05-31 07:22:20 +0000
@@ -186,7 +186,7 @@
           </p>
           <div>
             <input type="submit" name="import" value="Import Key"/>
-            or&nbsp; <a tal:attributes="href view/cancel_url">Cancel</a>
+            or&nbsp;<a tal:attributes="href view/cancel_url">Cancel</a>
           </div>
 
       </form>

=== modified file 'lib/lp/registry/templates/person-editsshkeys.pt'
--- lib/lp/registry/templates/person-editsshkeys.pt	2010-03-04 21:51:10 +0000
+++ lib/lp/registry/templates/person-editsshkeys.pt	2012-05-31 07:22:20 +0000
@@ -58,7 +58,7 @@
         </div>
         <div style="margin-top: 0.5em;">
           <input type="submit" value="Import Public Key" />
-          or&nbsp; <a tal:attributes="href view/cancel_url">Cancel</a>
+          or&nbsp;<a tal:attributes="href view/cancel_url">Cancel</a>
         </div>
       </div>
     </form>

=== modified file 'lib/lp/registry/templates/person-macros.pt'
--- lib/lp/registry/templates/person-macros.pt	2012-02-16 12:45:59 +0000
+++ lib/lp/registry/templates/person-macros.pt	2012-05-31 07:22:20 +0000
@@ -65,7 +65,7 @@
           tal:attributes="title context/subscriptionpolicy/description">
           <span tal:replace="context/subscriptionpolicy/title" />
           <a class="sprite maybe" href="/+help-registry/team-subscription-policy.html"
-            target="help">&nbsp;</a>
+            target="help"></a>
         </dd>
       </dl>
 

=== modified file 'lib/lp/registry/templates/person-portlet-contact-details.pt'
--- lib/lp/registry/templates/person-portlet-contact-details.pt	2012-02-16 20:37:55 +0000
+++ lib/lp/registry/templates/person-portlet-contact-details.pt	2012-05-31 07:22:20 +0000
@@ -72,8 +72,8 @@
       <dd>
         <img src="/@@/private" alt="" />
         <tal:openid-login content="view/openid_identity_url" />
-        <a target="help" href="/+help-registry/openid.html" class="sprite maybe">&nbsp;
-          <span class="invisible-link">OpenID help</span></a>
+        <a target="help" href="/+help-registry/openid.html"
+           class="sprite maybe"><span class="invisible-link">OpenID help</span></a>
       </dd>
     </dl>
 
@@ -183,8 +183,8 @@
       <dd><a id="karma-total"
              tal:attributes="href overview_menu/karma/url"
              tal:content="context/karma">342</a>
-          <a target="help" href="/+help-registry/karma.html" class="sprite maybe">&nbsp;
-          <span class="invisible-link">Karma help</span></a>
+          <a target="help" href="/+help-registry/karma.html"
+             class="sprite maybe"><span class="invisible-link">Karma help</span></a>
       </dd>
     </dl>
   </div>

=== modified file 'lib/lp/registry/templates/person-upcomingwork.pt'
--- lib/lp/registry/templates/person-upcomingwork.pt	2012-05-21 19:40:33 +0000
+++ lib/lp/registry/templates/person-upcomingwork.pt	2012-05-31 07:22:20 +0000
@@ -89,7 +89,7 @@
       <tbody>
         <tr class="expandable">
           <td>
-            <a href="#" class="expander">&nbsp;</a>
+            <a href="#" class="expander"></a>
             <span tal:replace="structure container/html_link" />
           </td>
           <td tal:content="structure container/target_link" />

=== modified file 'lib/lp/registry/templates/team-editproposed.pt'
--- lib/lp/registry/templates/team-editproposed.pt	2010-12-16 20:40:07 +0000
+++ lib/lp/registry/templates/team-editproposed.pt	2012-05-31 07:22:20 +0000
@@ -69,7 +69,7 @@
         </p>
 
         <input tal:replace="structure view/action_save/render" />
-        or&nbsp; <a tal:attributes="href view/cancel_url">Cancel</a>
+        or&nbsp;<a tal:attributes="href view/cancel_url">Cancel</a>
       </form>
       </div>
 

=== modified file 'lib/lp/soyuz/stories/distribution/xx-distribution-packages.txt'
--- lib/lp/soyuz/stories/distribution/xx-distribution-packages.txt	2012-02-21 22:46:28 +0000
+++ lib/lp/soyuz/stories/distribution/xx-distribution-packages.txt	2012-05-31 07:22:20 +0000
@@ -247,9 +247,7 @@
     >>> expander_url = find_tags_by_class(
     ...     user_browser.contents, 'expander')[0]
     >>> print expander_url
-    <a class="expander" href="/ubuntu/+archive/primary/+sourcepub/26/+listing-archive-extra" id="pub26-expander">
-      &nbsp;
-    </a>
+    <a class="expander" href="/ubuntu/+archive/primary/+sourcepub/26/+listing-archive-extra" id="pub26-expander"></a>
 
     >>> browser.open(user_browser.getLink(id="pub26-expander").url)
     >>> print extract_text(browser.contents)