Merge lp:~wallyworld/launchpad/improper-notification-removal into lp:launchpad
Proposed by
Ian Booth
Status: | Merged |
---|---|
Approved by: | Robert Collins |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12779 |
Proposed branch: | lp:~wallyworld/launchpad/improper-notification-removal |
Merge into: | lp:launchpad |
Diff against target: |
147 lines (+55/-31) 2 files modified
lib/lp/app/javascript/client.js (+42/-27) lib/lp/app/javascript/tests/test_lp_client.js (+13/-4) |
To merge this branch: | bzr merge lp:~wallyworld/launchpad/improper-notification-removal |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email: mp+56855@code.launchpad.net |
Commit message
[r=lifeless][bug=754058] Removal of existing notifications after patch requests is now explicit
Description of the change
After an xhr patch request, existing page notifications were being removed so that any new ones could be displayed in a clean context. However, this broke pages which issued several xhr calls during initial loading.
== Implementation ==
Make removal of notifications via javascript explicit. There is a lp_client remove_
== Tests ==
Modify existing lp_client javascript test plus add one new test:
test_
test_
To post a comment you must log in.