Merge lp:~wallyworld/launchpad/getSharedArtifacts-data-1049374 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15956 |
Proposed branch: | lp:~wallyworld/launchpad/getSharedArtifacts-data-1049374 |
Merge into: | lp:launchpad |
Diff against target: |
266 lines (+113/-51) 3 files modified
lib/lp/registry/interfaces/sharingservice.py (+34/-14) lib/lp/registry/services/sharingservice.py (+18/-3) lib/lp/registry/services/tests/test_sharingservice.py (+61/-34) |
To merge this branch: | bzr merge lp:~wallyworld/launchpad/getSharedArtifacts-data-1049374 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+124099@code.launchpad.net |
Commit message
Unexport the sharing service getSharedArtifacts, getVisibleArtifacts methods and export getSharedBugs, getSharedBranches.
Description of the change
== Implementation ==
The lazr restful infrastructure does not support fully deserialising collections containing heterogeneous elements, or non-trivial named operation return types like tuples of lists. In such cases, the return data contains json dicts of the attribute values for each item, but not web service Entry objects constructed from said data.
There are two sharing service methods recently exported:
getSharedArtifacts
getVisibleArtifacts
These were used internally first, and exported later.
Given the issues above, and the desire to return collections of web service Entry objects:
1. getSharedArtifacts and getVisibleArtifacts were unexported
2. getSharedBugs and getSharedBranches were added to the sharing service and exported
getSharedArtifacts is used internally to populate the model for the sharing details view. getSharedBugs and getSharedBranches just call this method and only return the relevant list of items.
AFAIK, getVisibleArtifacts was not used in any scripts - it was only exported because it was there.
Scripts which call getSharedArtifacts will now need to call getSharedBugs and getSharedBranches instead.
== Tests ==
Update the sharing service tests.
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
Thank you.