Merge lp:~wallyworld/launchpad/fix-sharing-terminology-948083 into lp:launchpad

Proposed by Ian Booth on 2012-03-08
Status: Merged
Approved by: Curtis Hovey on 2012-03-08
Approved revision: no longer in the source branch.
Merged at revision: 14924
Proposed branch: lp:~wallyworld/launchpad/fix-sharing-terminology-948083
Merge into: lp:launchpad
Prerequisite: lp:~wallyworld/launchpad/delete-pillar-observer-947947
To merge this branch: bzr merge lp:~wallyworld/launchpad/fix-sharing-terminology-948083
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code 2012-03-08 Approve on 2012-03-08
Review via email: mp+96506@code.launchpad.net

Commit Message

[r=sinzui][bug=948083] Fix terminology used for package names, modules, class names, variables, and parameters etc for sharing portion of the disclosure project.

Description of the Change

== Implementation ==

Fix terminology used for package names, modules, class names, variables, and parameters etc for sharing portion of the disclosure project.

eg
disclosure -> sharing
observer -> sharee
addPillarObserver -> addPillarSharee
AccessPolicyService -> SharingService

etc

== Tests ==

No new tests required.

== Lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/canonical/launchpad/icing/css/components/sharing.css
  lib/lp/registry/browser/pillar.py
  lib/lp/registry/browser/tests/test_pillar_sharing.py
  lib/lp/registry/interfaces/sharingservice.py
  lib/lp/registry/interfaces/webservice.py
  lib/lp/registry/javascript/sharing/pillarsharingview.js
  lib/lp/registry/javascript/sharing/shareepicker.js
  lib/lp/registry/javascript/sharing/shareetable.js
  lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html
  lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.js
  lib/lp/registry/javascript/sharing/tests/test_shareepicker.html
  lib/lp/registry/javascript/sharing/tests/test_shareepicker.js
  lib/lp/registry/javascript/sharing/tests/test_shareetable.html
  lib/lp/registry/javascript/sharing/tests/test_shareetable.js
  lib/lp/registry/services/configure.zcml
  lib/lp/registry/services/sharingservice.py
  lib/lp/registry/services/tests/test_sharingservice.py
  lib/lp/registry/templates/pillar-sharing.pt

To post a comment you must log in.
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)