Merge lp:~wallyworld/launchpad/dupe-project-warning-317258 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15751 |
Proposed branch: | lp:~wallyworld/launchpad/dupe-project-warning-317258 |
Merge into: | lp:launchpad |
Diff against target: |
240 lines (+82/-18) 8 files modified
lib/lp/bugs/browser/tests/test_bugs.py (+16/-3) lib/lp/bugs/interfaces/malone.py (+3/-2) lib/lp/bugs/javascript/bug_picker.js (+5/-2) lib/lp/bugs/javascript/duplicates.js (+26/-0) lib/lp/bugs/javascript/tests/test_bug_picker.js (+10/-4) lib/lp/bugs/javascript/tests/test_duplicates.js (+14/-0) lib/lp/code/javascript/tests/test_bugspeclinks.html (+2/-5) lib/lp/systemhomes.py (+6/-2) |
To merge this branch: | bzr merge lp:~wallyworld/launchpad/dupe-project-warning-317258 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email:
|
Commit message
Display a warning if a user wants to select a duplicate bug affecting a different project.
Description of the change
== Implementation ==
When a bug search is done for the bug picker, a new optional related_bug parameter is passed in. The json search results data contains a new 'different_pillars' attribute which is true if the search result bug and related bug do not have any target pillars in common.
The ui displays a warning if the bug data says that the proposed dupe and the context bug have no pillars in common.
== Demo and QA ==
http://
http://
== Tests ==
Enhance bug picker and duplicate bug yui tests.
Enhance getBugData() unit tests.
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
I think the code is good, as is the text. I don't think we want two warning messages to have different font weights. I don't think we need to make the message bold.