Merge lp:~wallyworld/launchpad/delete-bugtask-log-activity-1324 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Aaron Bentley |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14176 |
Proposed branch: | lp:~wallyworld/launchpad/delete-bugtask-log-activity-1324 |
Merge into: | lp:launchpad |
Prerequisite: | lp:~wallyworld/launchpad/delete-bugtasks-1324 |
Diff against target: |
236 lines (+119/-10) 7 files modified
lib/lp/bugs/adapters/bugchange.py (+22/-0) lib/lp/bugs/configure.zcml (+3/-0) lib/lp/bugs/mail/tests/test_bug_task_deletion.py (+42/-0) lib/lp/bugs/model/bugtask.py (+5/-1) lib/lp/bugs/model/tests/test_bugtask.py (+1/-4) lib/lp/bugs/subscribers/bugactivity.py (+16/-5) lib/lp/bugs/tests/test_bugchanges.py (+30/-0) |
To merge this branch: | bzr merge lp:~wallyworld/launchpad/delete-bugtask-log-activity-1324 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Aaron Bentley (community) | Approve | ||
Review via email: mp+79779@code.launchpad.net |
Commit message
[r=abentley,
Description of the change
Record bug activity and send email when bug task is deleted.
== Implementation ==
Provide a new bug change class: BugTaskDeleted
Provide an event subscriber for bugtask delete events. Record the bug change activity in the subscriber.
== Tests ==
Add a new test to TestBugChanges:
- test_bugtask_
Add a new test case similar to test_bug_
- test_bug_
(check that email is generated and correct header is present)
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Why the @block_ implicit_ flushes ?
If you plan on landing this branch separately from lp:~wallyworld/launchpad/delete-bugtasks-1324, I recommend creating a separate bug for it. It was a bit surprising that the linked bug was "Can't delete spurious "Affects" lines (bugtasks) from bug reports"