Launchpad itself

Merge lp:~wallyworld/launchpad/createAccessGrants-robust into lp:launchpad

  1. createAccessGrants-robust
  2. Merge into devel
Proposed by Ian Booth on 2012-06-04
Status: Merged
Approved by: William Grant on 2012-06-04
Approved revision: no longer in the source branch.
Merged at revision: 15359
Proposed branch: lp:~wallyworld/launchpad/createAccessGrants-robust
Merge into: lp:launchpad
Prerequisite: lp:~wallyworld/launchpad/sharing-jobs-config
Diff against target: 0 lines
To merge this branch: bzr merge lp:~wallyworld/launchpad/createAccessGrants-robust
Reviewer Review Type Date Requested Status
William Grant code 2012-06-04 Approve on 2012-06-04
Review via email: mp+108518@code.launchpad.net

Commit Message

Update sharing service createAccessGrant method to not barf if a grant already exists.

Description of the Change

== Implemenation ==

Rename ISharingService.createAccessGrants to ensureAccessGrants and make it check to see if any grants already exists and only create any missing ones.

== Tests ==

Update the sharing service tests which call _assert_ensureAccessGrants, and add a new test for the new method behaviour.

== Lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/model/bug.py
  lib/lp/registry/interfaces/sharingservice.py
  lib/lp/registry/services/sharingservice.py
  lib/lp/registry/services/tests/test_sharingser

To post a comment you must log in.
William Grant (wgrant) :
review: Approve (code)

Preview Diff

Empty