Code review comment for lp:~wallyworld/launchpad/893612-mail-too-big
Revision history for this message
| Ian Booth (wallyworld) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
No need to apologise. The test is perhaps not too brittle just at the
moment since the text snippets in the test are quite small and aligned
logically on sensible breaks so what's there works ok I think. Any
subsequent change to the code will need to test to be revisited anyway.
On Mon 16 Apr 2012 10:21:18 EST, Martin Pool wrote:
> :/ sorry.
>
> Unfortunately this test is probably a bit brittle, as it depends on exactly where the line breaks fall. It probably needs to be rewritten to something that matches whitespace regardless of linebreaks (maybe just comparing to body.replace('\n', ' ')).