Merge lp:~wallyworld/launchpad/893612-mail-too-big into lp:launchpad

Proposed by Ian Booth on 2012-04-16
Status: Merged
Approved by: Ian Booth on 2012-04-16
Approved revision: no longer in the source branch.
Merged at revision: 15100
Proposed branch: lp:~wallyworld/launchpad/893612-mail-too-big
Merge into: lp:launchpad
Prerequisite: lp:~mbp/launchpad/893612-mail-too-big
Diff against target: 0 lines
To merge this branch: bzr merge lp:~wallyworld/launchpad/893612-mail-too-big
Reviewer Review Type Date Requested Status
Ian Booth Pending
Review via email: mp+102045@code.launchpad.net

Commit message

Fix a test failure in TestIncoming.test_mail_too_big

Description of the change

Minor tweak to poolie's branch to fix test failure.

To post a comment you must log in.
Martin Pool (mbp) wrote :

:/ sorry.

Unfortunately this test is probably a bit brittle, as it depends on exactly where the line breaks fall. It probably needs to be rewritten to something that matches whitespace regardless of linebreaks (maybe just comparing to body.replace('\n', ' ')).

Ian Booth (wallyworld) wrote :

No need to apologise. The test is perhaps not too brittle just at the
moment since the text snippets in the test are quite small and aligned
logically on sensible breaks so what's there works ok I think. Any
subsequent change to the code will need to test to be revisited anyway.

On Mon 16 Apr 2012 10:21:18 EST, Martin Pool wrote:
> :/ sorry.
>
> Unfortunately this test is probably a bit brittle, as it depends on exactly where the line breaks fall. It probably needs to be rewritten to something that matches whitespace regardless of linebreaks (maybe just comparing to body.replace('\n', ' ')).

Preview Diff

Empty