Merge lp:~wallyworld/juju-core/fix-local-bootstrap-tools into lp:~go-bot/juju-core/trunk
Proposed by
Ian Booth
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tim Penhey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 2447 | ||||
Proposed branch: | lp:~wallyworld/juju-core/fix-local-bootstrap-tools | ||||
Merge into: | lp:~go-bot/juju-core/trunk | ||||
Diff against target: |
108 lines (+32/-20) 2 files modified
environs/bootstrap/bootstrap_test.go (+18/-9) environs/bootstrap/synctools.go (+14/-11) |
||||
To merge this branch: | bzr merge lp:~wallyworld/juju-core/fix-local-bootstrap-tools | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email: mp+211831@code.launchpad.net |
Commit message
Fix tools upload for local provider.
Local provider inserts agent-version into config
when the environment is opened and this was
preventing tools from being uploaded.
Description of the change
Fix tools upload for local provider.
Local provider inserts agent-version into config
when the environment is opened and this was
preventing tools from being uploaded.
To post a comment you must log in.
Reviewers: mp+211831_ code.launchpad. net,
Message:
Please take a look.
Description:
Fix tools upload for local provider.
Local provider inserts agent-version into config
when the environment is opened and this was
preventing tools from being uploaded.
https:/ /code.launchpad .net/~wallyworl d/juju- core/fix- local-bootstrap -tools/ +merge/ 211831
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/77960043/
Affected files (+34, -20 lines): bootstrap/ bootstrap_ test.go bootstrap/ synctools. go
A [revision details]
M environs/
M environs/
Index: [revision details] 20140319193533- t6r49574qjs0jkq w
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-
+New revision: <email address hidden>
Index: environs/ bootstrap/ bootstrap_ test.go bootstrap/ bootstrap_ test.go' bootstrap/ bootstrap_ test.go 2014-03-19 01:20:14 +0000 bootstrap/ bootstrap_ test.go 2014-03-19 22:02:00 +0000 bootstrap. SeriesToUpload( cfg, nil), gc.DeepEquals,
=== modified file 'environs/
--- environs/
+++ environs/
@@ -331,11 +331,13 @@
c.Assert(
[]string{"quantal", "precise", "lucid"})
}
-func (s *bootstrapSuite) assertUploadTools(c *gc.C, vers version.Binary, interface{ }, errMessage string) { (&version. Current, vers) interface{ }{"development" : allowRelease}) orage(c, env) RemoveFakeTools (c, env.Storage())
allowRelease bool, errMessage string) {
+func (s *bootstrapSuite) assertUploadTools(c *gc.C, vers version.Binary,
allowRelease bool,
+ extraConfig map[string]
+
s.PatchValue
// If we allow released tools to be uploaded, the build number is
incremented so in that case
// we need to ensure the environment is set up to allow dev tools to be
used.
- env := newEnviron("foo", useDefaultKeys,
map[string]
+ env := newEnviron("foo", useDefaultKeys, extraConfig)
s.setDummySt
envtesting.
@@ -372,17 +374,24 @@
func (s *bootstrapSuite) TestUploadTools(c *gc.C) { MustParseBinary ("1.19. 0-trusty- arm64") ools(c, vers, false, "") ReleaseVersionA llowed( c *gc.C) { MustParseBinary ("1.18. 0-trusty- arm64") ools(c, vers, true, "") ools(c, vers, false, nil, "") ForceVersionAll owsReleaseTools (c MustParseBinary ("1.18. 0-trusty- arm64") interface{ }{"development" : true} ools(c, vers, true, extraCfg, "") ForceVersionAll owsAgentVersion Set(c *gc.C) { MustParseBinary ("1.18. 0-trusty- arm64") interface{ }{"agent- version" : "1.18.0", "development": true} ools(c, vers, true, extraCfg, "")
vers := version.
- s.assertUploadT
-}
-
-func (s *bootstrapSuite) TestUploadTools
- vers := version.
- s.assertUploadT
+ s.assertUploadT
+}
+
+func (s *bootstrapSuite) TestUploadTools
*gc.C) {
+ vers := version.
+ extraCfg := map[string]
+ s.assertUploadT
+}
+
+func (s *bootstrapSuite)
TestUploadTools
+ vers := version.
+ extraCfg :=
map[string]
+ s.assertUploadT
}
func (s *bootstrapSuite) TestUploadTools ReleaseVersionD isallowed( c *gc.C) { MustParseBinary ("1.18. 0-trusty- arm64") ools(c, vers, false, "Juju cannot bootstrap because no
vers := version.
- s.assertUploadT
tools are available for your environment.*")
+ ...