Code review comment for lp:~wallyworld/goose/fix-nil-string-unmarshalling

Revision history for this message
Ian Booth (wallyworld) wrote :

Reviewers: mp+223017_code.launchpad.net,

Message:
Please take a look.

Description:
Fix unmarshalling of nil strings

In some nova structs sent and received over the
wire, serialised as json, there are id attributes
which can be string or int. We have custom marshalling
to handle that, but where the attributes were string
pointers, we were always unmarshalling as "" if the
value was nil. This broke things like floating ip
address usage.

https://code.launchpad.net/~wallyworld/goose/fix-nil-string-unmarshalling/+merge/223017

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/105180043/

Affected files (+71, -32 lines):
   A [revision details]
   M nova/json.go
   M nova/json_test.go

« Back to merge proposal