Reviewers: mp+214156_code.launchpad.net, thumper,

Message:
Running "go test -gocheck.f TestOpenFailsWithProtectedDirectories" in
provider/local raises the original make dir test fail: Juju should not
be able to create the dirs but can. My permissions are as follows:

ls -la /usr/lib | grep "juju"
drwxr-xr-x   5 root root         4096 Apr  4 17:00 juju
drwxr-xr-x   4 root root         4096 Apr  1 15:33 juju-1.17.7

If the fail is due to my perms, wouldn't this be a test isolation issue?


https://codereview.appspot.com/84360043/diff/1/cmd/jujud/upgrade_test.go
File cmd/jujud/upgrade_test.go (right):

https://codereview.appspot.com/84360043/diff/1/cmd/jujud/upgrade_test.go#newcode101
cmd/jujud/upgrade_test.go:101: // juju-local should have been installed.
On 2014/04/07 03:06:40, thumper wrote:
> This is not the right place to change this one.

> This test is explicitly checking that rsyslog-gnutls has been
installed due to
> changes in logging requirements.

Done.

https://codereview.appspot.com/84360043/diff/1/container/kvm/initialisation.go
File container/kvm/initialisation.go (right):

https://codereview.appspot.com/84360043/diff/1/container/kvm/initialisation.go#newcode47
container/kvm/initialisation.go:47: const neetToInstallKVMOk = `kvm-ok
is not installed. Please install the juju-local package.
On 2014/04/07 03:06:40, thumper wrote:
> Again, wrong place.  kvm-ok is in the cpu-checker package.

Done.

https://codereview.appspot.com/84360043/diff/1/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/84360043/diff/1/environs/cloudinit/cloudinit.go#newcode223
environs/cloudinit/cloudinit.go:223: c.AddPackage("juju-local")
On 2014/04/07 03:06:40, thumper wrote:
> This is definitely wrong.  Cloud-init is what we install on all the
cloud
> images.

Note to self: I should really take a moment to discuss and understand
what I'm doing before I go and do it.

https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go
File provider/local/prereqs.go (right):

https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go#newcode60
provider/local/prereqs.go:60: // I'm not sure what the path should be?
On 2014/04/07 03:06:40, thumper wrote:
> We don't need this any more

Done.

https://codereview.appspot.com/84360043/diff/1/provider/local/prereqs.go#newcode99
provider/local/prereqs.go:99: return errors.New(installJujuLocalUbuntu)
On 2014/04/07 03:06:40, thumper wrote:
> I'm pretty happy to just have this error returned in all cases.

> We can deal with the local provider in other platforms when it
happens.

Done.

Description:
Check only for juju-local package

Am I'm on the right track? mongodb-server, cpu-checker and
rsyslog-gnutls
are no longer checked for. Only juju-local is checked.

Branch currently fails with the following: On my local machine I get:

FAIL: environ_test.go:54:
environSuite.TestOpenFailsWithProtectedDirectories
	
	[LOG] 36.85478 INFO juju.provider.local opening environment "test"
	[LOG] 36.85478 TRACE juju.provider.local creating directory
/usr/lib/juju/storage
	[LOG] 36.85478 TRACE juju.provider.local creating directory
/usr/lib/juju/db
	[LOG] 36.85478 DEBUG juju.provider.local getAddressForInterface called
for lxcbr0
	[LOG] 36.85478 DEBUG juju.provider.local found "127.0.0.1" as address
for "lxcbr0"
	environ_test.go:63:
	    c.Assert(err, gc.ErrorMatches, "mkdir .* permission denied")
	... value = nil
	... regex string = "mkdir .* permission denied"
	... Error value is nil
	
	--- FAIL: TestLocal (10.77 seconds)
	FAIL
	exit status 1
	FAIL	launchpad.net/juju-core/provider/local	10.850s

On my PPC VM I get:

provider/local_test
./config_test.go:36:22: error: reference to undefined identifier
'local.Provider'

I have not tracked down why yet.

https://code.launchpad.net/~waigani/juju-core/1301353-mongodb-dep/+merge/214156

(do not edit description out of merge proposal)


Please review this at https://codereview.appspot.com/84360043/

Affected files (+18, -194 lines):
   M Makefile
   A [revision details]
   M container/kvm/initialisation.go
   M provider/local/prereqs.go
   M provider/local/prereqs_test.go