Merge ~vultaire/charm-prometheus-blackbox-exporter:makefile-20.08 into charm-prometheus-blackbox-exporter:master
Proposed by
Paul Goins
Status: | Merged |
---|---|
Merged at revision: | c541de54c0543f7614ff067ba0a39cfadf6fc729 |
Proposed branch: | ~vultaire/charm-prometheus-blackbox-exporter:makefile-20.08 |
Merge into: | charm-prometheus-blackbox-exporter:master |
Diff against target: |
388 lines (+153/-99) 5 files modified
.gitignore (+26/-9) Makefile (+57/-25) dev/null (+0/-65) src/tests/unit/requirements.txt (+1/-0) src/tox.ini (+69/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Xav Paice (community) | Approve | ||
Review via email: mp+388595@code.launchpad.net |
Commit message
Updated Makefile/
Description of the change
Note: this charm lacked any unit tests, so while I fixed things so the unit tests would pass if there were any to test, the "make unittests" target _does_ fail since there are no tests (and thus no coverage data).
I could add a dummy test if strongly desired, but I feel like that could unintentionally "cover up" that this charm has no unit tests. At the very least I want to call this out so we can decide what to do here.
To post a comment you must log in.
Also note that the 'Fixed "make lint"' commit is a combination of tox.ini tweaks and running black, and nothing more.