~vultaire/charm-nrpe:host-container-check-rework

Branch merges

Propose for merging

Merged into charm-nrpe:master at revision 989b71a53179c762a299f9085ce4d788d207b14e

🤖 prod-jenkaas-bootstack (community): Approve (continuous-integration) on 2021-08-17

BootStack Reviewers: Pending requested 2021-08-17

BootStack Reviewers: Pending requested 2021-08-17

Diff: 356 lines (+167/-74)

6 files modified

hooks/nrpe_helpers.py (+79/-74)
tests/functional/tests/bundles/bionic.yaml (+6/-0)
tests/functional/tests/bundles/focal.yaml (+6/-0)
tests/functional/tests/bundles/xenial.yaml (+6/-0)
tests/functional/tests/nrpe_tests.py (+66/-0)
tests/functional/tests/tests.yaml (+4/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

a01359b... by Paul Goins on 2021-08-17

Refactored out a helper function for comparing sets

a8dc2c8... by Paul Goins on 2021-08-17

Reworked some checks to only run on hosts

Some checks have limited to no meaning when run on containers. This
patch tries to change some of those checks so they're only enabled and
installed on host machines.

Do note that this does impact testing. Functional tests expect that
the main machines of the model are not containers, and a newly added
test for this functionality will fail if it is run on an LXD-based
Juju controller.

9472218... by Connor Chamberlain on 2021-08-12

Added "auto" option to nagios_hostname_type config

Reviewed-on: https://code.launchpad.net/~lcvcode/charm-nrpe/+git/charm-nrpe/+merge/406962
Reviewed-by: Drew Freiberger <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: James Troup <email address hidden>

5071112... by Connor Chamberlain on 2021-08-11

Added "auto" option to nagios_hostname_type config

* "auto" is the new default value for this config
* When set, bare-metal hosts will provide their hostname to nagios
* When set, non-metal hosts will provide their unit name to nagios

3456a4f... by Connor Chamberlain on 2021-08-10

Added model uuid to monitors relation

Reviewed-on: https://code.launchpad.net/~lcvcode/charm-nrpe/+git/charm-nrpe/+merge/406843
Reviewed-by: Drew Freiberger <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: James Troup <email address hidden>

01f5bab... by Connor Chamberlain on 2021-08-06

Added model uuid to monitors relation

7fad0fa... by Xav Paice on 2021-07-30

Improvements to functional testing

* Remove Trusty support
* Add functional tests for Focal
* charmhelpers update
* Lint fixes

Reviewed-on: https://code.launchpad.net/~xavpaice/charm-nrpe/+git/nrpe-charm/+merge/406421
Reviewed-by: Paul Goins <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Xiyue Wang <email address hidden>

aa9e5a7... by Xav Paice on 2021-07-30

Add submodules to build step

ecb7192... by Xav Paice on 2021-07-30

remove Trusty support

77dcc14... by Xav Paice on 2021-07-30

Update functests for Focal