charm-kubernetes-service-checks

Merge ~vultaire/charm-kubernetes-service-checks:charmcraft-version-limit into charm-kubernetes-service-checks:master

  1. Git
  2. lp:~vultaire/charm-kubernetes-service-checks
  3. charmcraft-version-limit
  4. Merge into master
Proposed by Paul Goins
Status: Merged
Merged at revision: 1c0b85ae563254ed350bf71e10d0c97d8000620a
Proposed branch: ~vultaire/charm-kubernetes-service-checks:charmcraft-version-limit
Merge into: charm-kubernetes-service-checks:master
Diff against target: 13 lines (+1/-1)
1 file modified
tox.ini (+1/-1)
Reviewer Review Type Date Requested Status
Andrea Ieri Approve
Xav Paice (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Review via email: mp+406265@code.launchpad.net

Commit message

Temporarily limit charmcraft version to avoid behavior changes

charmcraft>=1.1.0 leverages charmcraft.yaml to drive building of potentially multiple distinct charm files targeting different channels or architectures. In the short term, these changes break "make release". We will need to update things eventually to work with the newer charmcraft, but preferably after this release.

To post a comment you must log in.
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

PASSED: Continuous integration, rev:1c0b85ae563254ed350bf71e10d0c97d8000620a
https://jenkins.canonical.com/bootstack/job/lp-charm-kubernetes-service-checks-ci/10/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-unit/142/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/352/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-kubernetes-service-checks-ci/10//rebuild

review: Approve (continuous-integration)
Revision history for this message
Xav Paice (xavpaice) wrote :

LGTM

review: Approve
Revision history for this message
Andrea Ieri (aieri) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tox.ini b/tox.ini
2index 328cb22..a435b08 100644
3--- a/tox.ini
4+++ b/tox.ini
5@@ -33,7 +33,7 @@ passenv =
6 OS_IDENTITY_API_VERSION
7
8 [testenv:build]
9-deps = charmcraft
10+deps = charmcraft<1.1.0
11 commands = charmcraft build
12
13 [testenv:lint]

Subscribers

People subscribed via source and target branches

to all changes: