Merge lp:~vthompson/urps/fix-label into lp:urps

[Victor Thompson]

Fix name label

Fix name label

[Max Tither (11ubuntucg)]

Your fix is excellent. The only issue I have is in the runtime, when a user click the number of rounds they want for the game and moves to the next page, it will display the round specified the last time the game was played(as it was saved in the db). This is the major setback I have. for the record, I want to display the rounds selected in the game title under the variable "gameLength".

The reason at first I said that the name was an issue was because I thought that the two would be similar, but that is not the case. I tried to apply the fix you did with the label to the round numbers, but to no success. I did update a new verson of the app with your fix. Should you fix this last thing, then I will merge everything into the code.

Thank you,
Max Tither

review: Needs Fixing (runtime review)

Unmerged revisions

2. By Victor Thompson on 2013-10-22

fix name label

=== modified file 'ubunturockpaperscissors.qml'
--- ubunturockpaperscissors.qml	2013-10-21 23:46:11 +0000
+++ ubunturockpaperscissors.qml	2013-10-22 00:26:13 +0000
@@ -20,7 +20,8 @@
 
     //Here will begin the database code:
 
-    //property var gameLength: getSetting("gameLength")
+    property string gameLength: getSetting("gameLength")
+    property string playerName: getSetting("playerName")
     signal buttonClicked
     property var db: null
 
@@ -217,6 +218,8 @@
                                             }
                                             console.log("Saved " + gameLength);
                                             saveSetting("gameLength", gameLength);
+                                            playerName = playerNameInput.text;
+                                            saveSetting("playerName", playerName);
                                             buttonClicked(
                                             getSetting('gameLength'));
                                             console.log("retrieved " + gameLength);
@@ -264,11 +267,10 @@
 
                    Label {
 
-                      property var gameLength: getSetting("gameLength")
                       id: playerNameLabel
 
                       anchors.centerIn: parent
-                            text: ("The Players Name is "+ gameLength)
+                            text: ("The Players Name is "+ playerName)
 
                       fontSize: "large"
                   }