Merge lp:~vthompson/unity-mir/fixes-1241045 into lp:unity-mir

Proposed by Victor Thompson
Status: Merged
Approved by: Gerry Boland
Approved revision: 148
Merged at revision: 153
Proposed branch: lp:~vthompson/unity-mir/fixes-1241045
Merge into: lp:unity-mir
Diff against target: 11 lines (+1/-1)
1 file modified
src/modules/Unity/Application/application_manager.cpp (+1/-1)
To merge this branch: bzr merge lp:~vthompson/unity-mir/fixes-1241045
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Gerry Boland (community) Approve
Review via email: mp+196415@code.launchpad.net

Commit message

Fix mir to not suspend the music-app, or any other app granted a lifecycle exception, when switching between apps.

Description of the change

Fix mir to not suspend the music-app, or any other app granted a lifecycle exception, when switching between apps.

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Look good to me, thanks for this Victor!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

Landing failed as Mir has progressed to 0.1.2 and this MR needs to land first: https://code.launchpad.net/~gerboland/unity-mir/0.1.2-supprt/+merge/196693
So holding off until then

Revision history for this message
Gerry Boland (gerboland) wrote :

Ok trying again

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/modules/Unity/Application/application_manager.cpp'
2--- src/modules/Unity/Application/application_manager.cpp 2013-11-15 17:53:17 +0000
3+++ src/modules/Unity/Application/application_manager.cpp 2013-11-23 06:15:06 +0000
4@@ -545,7 +545,7 @@
5 return;
6
7 // set state of previously focused app to suspended
8- if (m_focusedApplication && !m_lifecycleExceptions.contains(m_focusedApplication->appId())) {
9+ if (m_focusedApplication && m_lifecycleExceptions.filter(m_focusedApplication->appId().section('_',0,0)).empty()) {
10 m_focusedApplication->setState(Application::Suspended);
11 }
12

Subscribers

People subscribed via source and target branches