Merge lp:~vthompson/ubuntu-weather-app/weather-updated-icon into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Victor Thompson on 2015-05-21
Status: Merged
Approved by: Nicholas Skaggs on 2015-10-21
Approved revision: 414
Merged at revision: 422
Proposed branch: lp:~vthompson/ubuntu-weather-app/weather-updated-icon
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 17 lines (+7/-0)
1 file modified
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/weather-updated-icon
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve on 2015-10-21
Andrew Hayzen 2015-05-21 Approve on 2015-07-13
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-07-13
Review via email: mp+259762@code.launchpad.net

Commit message

Switch to new icon

Description of the change

Switch to new icon

To post a comment you must log in.
Victor Thompson (vthompson) wrote :

Do we want to land this in the app that is currently in the store?

We want to land this in the store alongside the other apps. So we need to land it in trunk, certainly. We can then pick our time for store upload.

Andrew Hayzen (ahayzen) wrote :

LGTM :-)

review: Approve
Bartosz Kosiorek (gang65) wrote :

There is an error:
dpkg-source: error: cannot represent change to weather-app@30.png: binary file contents changed

Please cheange an debian/changelog to fix that issue.

Victor Thompson (vthompson) wrote :

Thanks Bartosz!

Andrew Hayzen (ahayzen) wrote :

Thanks Bartosz for the hint. LGTM, please be nice jenkins :-)

review: Approve

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/weather-app-autolanding/1/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1/console

review: Needs Fixing (continuous-integration)
review: Approve (continuous-integration)

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/weather-app-autolanding/2/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/2/console

review: Needs Fixing (continuous-integration)
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-09-25 09:56:58 +0000
3+++ debian/changelog 2015-07-13 12:21:35 +0000
4@@ -1,3 +1,10 @@
5+ubuntu-weather-app (1.8.3ubuntu2) vivid; urgency=medium
6+
7+ [ Victor Thompson ]
8+ * Use new app icon
9+
10+ -- Victor Thompson <victor.thompson@gmail.com> Mon, 13 Jul 2015 07:00:55 -0500
11+
12 ubuntu-weather-app (1.8.3ubuntu1) utopic; urgency=low
13
14 [ Dan Chapman ]
15
16=== modified file 'weather-app@30.png'
17Binary files weather-app@30.png 2014-02-18 21:26:36 +0000 and weather-app@30.png 2015-07-13 12:21:35 +0000 differ

Subscribers

People subscribed via source and target branches