Merge lp:~vthompson/ubuntu-weather-app/transparent-legacy-listitems-with-bg into lp:~ahayzen/ubuntu-weather-app/transparent-legacy-listitems

Proposed by Victor Thompson on 2015-10-04
Status: Work in progress
Proposed branch: lp:~vthompson/ubuntu-weather-app/transparent-legacy-listitems-with-bg
Merge into: lp:~ahayzen/ubuntu-weather-app/transparent-legacy-listitems
Diff against target: 12 lines (+1/-1)
1 file modified
app/ui/HomePage.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/transparent-legacy-listitems-with-bg
Reviewer Review Type Date Requested Status
Victor Thompson (community) Disapprove on 2015-10-17
Andrew Hayzen 2015-10-04 Pending
Review via email: mp+273347@code.launchpad.net

Commit message

Make background #F5F5F5.

Description of the change

Perhaps we should make the bg of the home screen the same as the designed app's bg color?

To post a comment you must log in.
Victor Thompson (vthompson) wrote :

Actually, this makes the large weather icons look odd as they have a pure white background.

review: Disapprove

Unmerged revisions

131. By Victor Thompson on 2015-10-04

Make background #F5F5F5.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ui/HomePage.qml'
2--- app/ui/HomePage.qml 2015-09-05 00:03:33 +0000
3+++ app/ui/HomePage.qml 2015-10-04 19:13:56 +0000
4@@ -89,7 +89,7 @@
5 Rectangle {
6 id: pageBackground
7 anchors.fill: parent
8- color: "white"
9+ color: weatherApp.backgroundColor
10 }
11
12 /*

Subscribers

People subscribed via source and target branches

to all changes: