Merge lp:~vthompson/ubuntu-weather-app/transparent-legacy-listitems-with-bg into lp:~ahayzen/ubuntu-weather-app/transparent-legacy-listitems
Proposed by
Victor Thompson
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp:~vthompson/ubuntu-weather-app/transparent-legacy-listitems-with-bg |
| Merge into: | lp:~ahayzen/ubuntu-weather-app/transparent-legacy-listitems |
| Diff against target: |
12 lines (+1/-1) 1 file modified
app/ui/HomePage.qml (+1/-1) |
| To merge this branch: | bzr merge lp:~vthompson/ubuntu-weather-app/transparent-legacy-listitems-with-bg |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Victor Thompson (community) | Disapprove | ||
| Andrew Hayzen | Pending | ||
|
Review via email:
|
|||
Commit message
Make background #F5F5F5.
Description of the change
Perhaps we should make the bg of the home screen the same as the designed app's bg color?
To post a comment you must log in.
Revision history for this message
| Victor Thompson (vthompson) wrote | # |
Revision history for this message
| Victor Thompson (vthompson) | # |
review:
Disapprove
Unmerged revisions
- 131. By Victor Thompson
-
Make background #F5F5F5.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Actually, this makes the large weather icons look odd as they have a pure white background.