Merge lp:~vthompson/ubuntu-weather-app/reboot-stay-on-location-upon-refresh into lp:ubuntu-weather-app

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 47
Merged at revision: 51
Proposed branch: lp:~vthompson/ubuntu-weather-app/reboot-stay-on-location-upon-refresh
Merge into: lp:ubuntu-weather-app
Diff against target: 11 lines (+1/-0)
1 file modified
app/ui/HomePage.qml (+1/-0)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/reboot-stay-on-location-upon-refresh
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+261317@code.launchpad.net

Commit message

* Do not lose currentIndex when pull to refresh.

Description of the change

* Do not lose currentIndex when pull to refresh.

Currently if the user has 2 or more locations and the user does a "Pull to refresh" on any location the user is brought to the location at index 0. The user should say on the location that the refresh was done upon.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

There is a similar issue when you add/remove locations, can this be solved by a similar change?

review: Needs Information
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

After further discussions, we'll land as is and sort out the other cases in another branch :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ui/HomePage.qml'
2--- app/ui/HomePage.qml 2015-05-29 02:38:23 +0000
3+++ app/ui/HomePage.qml 2015-06-06 17:49:27 +0000
4@@ -108,6 +108,7 @@
5 parent: locationFlickable
6 refreshing: false
7 onRefresh: {
8+ locationPages.loaded = false
9 refreshing = true
10 refreshData(false, true)
11 }

Subscribers

People subscribed via source and target branches

to all changes: