Merge lp:~vthompson/ubuntu-weather-app/reboot-lock-portrait into lp:ubuntu-weather-app

Proposed by Victor Thompson on 2015-08-21
Status: Merged
Approved by: Andrew Hayzen on 2015-08-25
Approved revision: 100
Merged at revision: 103
Proposed branch: lp:~vthompson/ubuntu-weather-app/reboot-lock-portrait
Merge into: lp:ubuntu-weather-app
Diff against target: 20 lines (+2/-0)
2 files modified
debian/changelog (+1/-0)
ubuntu-weather-app.desktop.in.in (+1/-0)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/reboot-lock-portrait
Reviewer Review Type Date Requested Status
Andrew Hayzen 2015-08-21 Approve on 2015-08-25
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-08-21
Review via email: mp+268807@code.launchpad.net

Commit message

* Lock app in portrait mode

Description of the change

* Lock app in portrait mode

Currently, it doesn't appear that an app can change orientation and be in the sidestage when in landscape. I say we just land a lock to portrait mode until something like this can be done.

To post a comment you must log in.
Andrew Hayzen (ahayzen) wrote :

LGTM :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-08-20 14:53:54 +0000
3+++ debian/changelog 2015-08-21 21:25:49 +0000
4@@ -21,6 +21,7 @@
5 * Create autopilot test which changes the selected location (LP: #1452494)
6 * When location detection is off, make sure the correct location can be
7 selected (LP: #1482936)
8+ * Lock app in portrait mode
9
10 [ Andrew Hayzen ]
11 * Add mocked locations for autopilot and add a test using the data
12
13=== modified file 'ubuntu-weather-app.desktop.in.in'
14--- ubuntu-weather-app.desktop.in.in 2015-01-23 23:15:52 +0000
15+++ ubuntu-weather-app.desktop.in.in 2015-08-21 21:25:49 +0000
16@@ -10,3 +10,4 @@
17 X-Ubuntu-Touch=true
18 X-Ubuntu-Default-Department-ID=accessories
19 X-Ubuntu-Splash-Color=#F5F5F5
20+X-Ubuntu-Supported-Orientations=portrait

Subscribers

People subscribed via source and target branches

to all changes: