Ubuntu Weather App

Merge lp:~vthompson/ubuntu-weather-app/reboot-icon-fix into lp:ubuntu-weather-app

  1. reboot-icon-fix
  2. Merge into reboot
Proposed by Victor Thompson
Status: Merged
Approved by: Bartosz Kosiorek
Approved revision: 62
Merged at revision: 61
Proposed branch: lp:~vthompson/ubuntu-weather-app/reboot-icon-fix
Merge into: lp:ubuntu-weather-app
Diff against target: 28 lines (+3/-5)
2 files modified
CMakeLists.txt (+1/-1)
app/CMakeLists.txt (+2/-4)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/reboot-icon-fix
Reviewer Review Type Date Requested Status
Bartosz Kosiorek (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+263513@code.launchpad.net

Commit message

Add icon file into debian package

Description of the change

Add icon file into debian package

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:61
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/135/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/105/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/135/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/135/rebuild

review: Needs Fixing (continuous-integration)
lp:~vthompson/ubuntu-weather-app/reboot-icon-fix updated
62. By Victor Thompson

Bump rev

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:62
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/136/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/106
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/136

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/136/rebuild

review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Looks good to me. Thanks

review: Approve
Revision history for this message
Victor Thompson (vthompson) wrote :

I have my PPA running against this branch and I don't think it's working
yet, unfortunately.
On Jul 1, 2015 9:29 AM, "Bartosz Kosiorek" <email address hidden> wrote:

> Review: Approve
>
> Looks good to me. Thanks
> --
>
> https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-icon-fix/+merge/263513
> You are the owner of lp:~vthompson/ubuntu-weather-app/reboot-icon-fix.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2015-05-22 00:13:54 +0000
3+++ CMakeLists.txt 2015-07-01 12:38:21 +0000
4@@ -33,7 +33,7 @@
5 set(APP_HARDCODE ubuntu-weather-app)
6 set(MAIN_QML ${APP_HARDCODE}.qml)
7 set(DESKTOP_FILE "${APP_HARDCODE}.desktop")
8-set(ICON weather-app@30.png)
9+set(ICON_FILE weather-app@30.png)
10 set(AUTOPILOT_DIR ubuntu_weather_app)
11
12 # Set install paths
13
14=== modified file 'app/CMakeLists.txt'
15--- app/CMakeLists.txt 2015-02-08 20:56:21 +0000
16+++ app/CMakeLists.txt 2015-07-01 12:38:21 +0000
17@@ -4,10 +4,8 @@
18 endif(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
19
20
21-if(CLICK_MODE)
22- set(ICON ${ICON})
23- install(FILES ${ICON} DESTINATION ${CMAKE_INSTALL_PREFIX})
24-endif(CLICK_MODE)
25+set(ICON ${ICON_FILE})
26+install(FILES ${ICON} DESTINATION ${CMAKE_INSTALL_PREFIX})
27
28 install(FILES ${MAIN_QML} DESTINATION ${UBUNTU-WEATHER_APP_DIR})
29

Subscribers

People subscribed via source and target branches

to all changes: