Merge lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage into lp:ubuntu-weather-app

[Victor Thompson]

Get initial data from storage to not block the UI thread.

Nik had noticed that the app is blank when it is started. I'm 99% sure that is due to the initial refresh blocking the UI. I had the same issue with both OWM and TWC today. Ideally this should be done in a workerscript, but the solution here is a good temporary workaround.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:20
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/45/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/15
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/45

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/45/rebuild

review: Approve (continuous-integration)

[Martin Borho (martin-borho)]

The requests to the API where originally in a WorkerScript, but a former Qt upgrade (5.2?!) broke it terribly. So I've removed it. Don't know if would work again now in a WorkerScript, some time gone by since then. Should be easy to reimplement again, the revision it was changed: http://bazaar.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/trunk/revision/219

For me the problem is, that JSON in Qt was always riddled with nasty bugs...

[Martin Borho (martin-borho)]

I've readded the worker, seems to work again

https://code.launchpad.net/~martin-borho/ubuntu-weather-app/reboot-worker

Try out, if this would work out for us?

[Victor Thompson (vthompson)]

It doesn't seem to unblock the UI. I still get a blank screen with no settings icon. OWM still seems to be down, so you can test against that if you want. Here's an example URL:

http://api.openweathermap.org/data/2.5/forecast/daily?id=5037649&cnt=10&units=metric

I wonder if in the future we should try to use a different data provider if one is down?

[lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage]

21. By Victor Thompson on 2015-03-14

revamp solution

[Victor Thompson (vthompson)]

I've got a better idea for this MP. How about we initialize with stored data, and then do a force refresh? I made an update to do this.

[lp:~vthompson/ubuntu-weather-app/reboot-get-initial-data-from-storage]

22. By Victor Thompson on 2015-03-14

update

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:21
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/46/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/16
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/46

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/46/rebuild

review: Approve (continuous-integration)

[Victor Thompson (vthompson)]

Ok, one last thought on this. I tried your MP with the solution below and it works well. Could you propose your reboot-worker mp with the following change?

12 - Component.onCompleted: refreshData();
13 + Component.onCompleted: {
14 + storage.getLocations(fillPages);
15 + refreshData();
16 + }

I think always starting with stored data and then spinning off the request in a worker is probably the best solution for now. What do you think?

[Martin Borho (martin-borho)]

Perfect! :)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:22
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/47/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/17
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/47

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/47/rebuild

review: Approve (continuous-integration)

=== modified file 'app/ubuntu-weather-app.qml'
--- app/ubuntu-weather-app.qml	2015-03-08 17:23:58 +0000
+++ app/ubuntu-weather-app.qml	2015-03-14 15:01:50 +0000
@@ -56,8 +56,14 @@
 
     /*
       (re)load the pages on completion
+      TODO: Currently this is done from storage because the request blocks the
+            UI. Ideally the request to the APIs should be done via a
+            WorkerScript
     */
-    Component.onCompleted: refreshData();
+    Component.onCompleted: {
+        storage.getLocations(fillPages);
+        refreshData();
+    }
 
     /*
       Handle response data from data backend. Checks if a location