Merge lp:~vthompson/ubuntu-weather-app/msg-when-no-keys into lp:ubuntu-weather-app
Proposed by
Victor Thompson
Status: | Merged |
---|---|
Approved by: | Andrew Hayzen |
Approved revision: | 166 |
Merged at revision: | 166 |
Proposed branch: | lp:~vthompson/ubuntu-weather-app/msg-when-no-keys |
Merge into: | lp:ubuntu-weather-app |
Diff against target: |
149 lines (+91/-2) 4 files modified
app/components/NoAPIKeyErrorStateComponent.qml (+62/-0) app/ui/HomePage.qml (+12/-1) debian/changelog (+6/-0) po/com.ubuntu.weather.pot (+11/-1) |
To merge this branch: | bzr merge lp:~vthompson/ubuntu-weather-app/msg-when-no-keys |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrew Hayzen | Approve | ||
Alan Pope πΊπ§π± π¦ (community) | Approve | ||
Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+277080@code.launchpad.net |
Commit message
* Create an error state when there are no keys found.
Description of the change
* Create an error state when there are no keys found.
To post a comment you must log in.
PASSED: Continuous integration, rev:165 /core-apps- jenkins. ubuntu. com/job/ weather- app-ci/ 14/ /core-apps- jenkins. ubuntu. com/job/ generic- update- mp/123/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /core-apps- jenkins. ubuntu. com/job/ weather- app-ci/ 14/rebuild
https:/