Ubuntu Weather App

Merge lp:~vthompson/ubuntu-weather-app/fix-1478183 into lp:ubuntu-weather-app

  1. fix-1478183
  2. Merge into reboot
Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 81
Merged at revision: 82
Proposed branch: lp:~vthompson/ubuntu-weather-app/fix-1478183
Merge into: lp:ubuntu-weather-app
Diff against target: 42 lines (+3/-3)
3 files modified
CMakeLists.txt (+1/-1)
app/CMakeLists.txt (+0/-1)
debian/changelog (+2/-1)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/fix-1478183
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+266823@code.launchpad.net

Commit message

* Fix the CMakeLists.txt to include the app icon

Description of the change

* Fix the CMakeLists.txt to include the app icon

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:80
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/172/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/142
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/172

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/172/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

The icon is back! LGTM :-)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-autolanding/80/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-autolanding/71/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-autolanding/80/console

review: Needs Fixing (continuous-integration)
lp:~vthompson/ubuntu-weather-app/fix-1478183 updated
81. By Victor Thompson

Merge trunk/reboot and resolve conflicts

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:81
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/177/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-utopic-amd64-ci/147
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-vivid-amd64-ci/177

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-reboot-ci/177/rebuild

review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2015-07-01 12:22:16 +0000
3+++ CMakeLists.txt 2015-08-07 00:12:27 +0000
4@@ -33,7 +33,7 @@
5 set(APP_HARDCODE ubuntu-weather-app)
6 set(MAIN_QML ${APP_HARDCODE}.qml)
7 set(DESKTOP_FILE "${APP_HARDCODE}.desktop")
8-set(ICON_FILE weather-app@30.png)
9+set(ICON weather-app@30.png)
10 set(AUTOPILOT_DIR ubuntu_weather_app)
11
12 # Set install paths
13
14=== modified file 'app/CMakeLists.txt'
15--- app/CMakeLists.txt 2015-07-01 12:38:05 +0000
16+++ app/CMakeLists.txt 2015-08-07 00:12:27 +0000
17@@ -4,7 +4,6 @@
18 endif(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
19
20
21-set(ICON ${ICON_FILE})
22 install(FILES ${ICON} DESTINATION ${CMAKE_INSTALL_PREFIX})
23
24 install(FILES ${MAIN_QML} DESTINATION ${UBUNTU-WEATHER_APP_DIR})
25
26=== modified file 'debian/changelog'
27--- debian/changelog 2015-08-06 01:34:38 +0000
28+++ debian/changelog 2015-08-07 00:12:27 +0000
29@@ -1,4 +1,4 @@
30-ubuntu-weather-app (3.0) UNRELEASED; urgency=medium
31+ubuntu-weather-app (3.0ubuntu1) UNRELEASED; urgency=medium
32
33 [ Victor Thompson ]
34 * Sync debian version with click version.
35@@ -8,6 +8,7 @@
36 * Add conditions text to day delegate.
37 * Default to OWM if the key file for TWC is blank.
38 * Add sunrise and sunset icons from the spec
39+ * Fix the CMakeLists.txt to include the app icon
40
41 [ Andrew Hayzen ]
42 * Add mocked locations for autopilot and add a test using the data

Subscribers

People subscribed via source and target branches

to all changes: