Merge lp:~vthompson/ubuntu-terminal-app/fix-1380812 into lp:ubuntu-terminal-app

[Victor Thompson]

* Call header hide or show when changing orientation.

Also call header hide or show when changing orientation.

Could someone also verify that lp:1288343 is fixed with this change? Adding popey as a required reviewer.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:175
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/120/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/136
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/136/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-vivid-amd64-ci/4

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/120/rebuild

review: Approve (continuous-integration)

[Filippo Scognamiglio (flscogna)]

review: Approve

[lp:~vthompson/ubuntu-terminal-app/fix-1380812]

176. By Victor Thompson on 2014-11-19

Seemingly fix the header being covered when the app is started on a Nexus 7, need to know why

[Victor Thompson (vthompson)]

I was able to verify the fix for lp:1288343 on my Nexus 7, however, the behavior in lp:1380812 occurs when the app is started--without rotating the screen on the Nexus 7. I've added a work around for this, but this I'm not sure why the work around fixes the issue.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:176
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/121/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/288
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/288/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-vivid-amd64-ci/5

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/121/rebuild

review: Approve (continuous-integration)

=== modified file 'src/app/qml/ubuntu-terminal-app.qml'
--- src/app/qml/ubuntu-terminal-app.qml	2014-09-20 10:54:37 +0000
+++ src/app/qml/ubuntu-terminal-app.qml	2014-11-19 03:42:12 +0000
@@ -32,16 +32,29 @@
             title: i18n.tr("Terminal")
 
             onWidthChanged: {
-                header.visible = width < height;
+                if (width < height) {
+                    header.visible = true
+                    header.show()
+                } else {
+                    header.visible = false
+                    header.hide()
+                }
             }
 
             onHeightChanged: {
-                header.visible = width < height;
+                if (width < height) {
+                    header.visible = true
+                    header.show()
+                } else {
+                    header.visible = false
+                    header.hide()
+                }
             }
 
             Terminal {
                 id: pgTerm
                 objectName: "pgTerm"
+                Component.onCompleted: header.visible = false
             }
 
             head.actions: [