Ubuntu Shorts App

Merge lp:~vthompson/ubuntu-rssreader-app/fix-1357639 into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

  1. fix-1357639
  2. Merge into trunk
Proposed by Victor Thompson
Status: Merged
Approved by: Joey Chan
Approved revision: 291
Merged at revision: 291
Proposed branch: lp:~vthompson/ubuntu-rssreader-app/fix-1357639
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
imgSeparator.js (+1/-1)
To merge this branch: bzr merge lp:~vthompson/ubuntu-rssreader-app/fix-1357639
Reviewer Review Type Date Requested Status
Joey Chan Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+231059@code.launchpad.net

Commit message

Fix unterminated string literal

Description of the change

Fix unterminated string literal

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:291
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/257/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1557
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1557/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-rssreader-app-utopic-amd64-ci/36

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-rssreader-app-ci/257/rebuild

review: Approve (continuous-integration)
Revision history for this message
Joey Chan (qqworini) wrote :

lol

thx for fixing my stupid mistake

review: Approve
Revision history for this message
Roman Shchekin (mrqtros) wrote :

Funny mistake)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'imgSeparator.js'
2--- imgSeparator.js 2014-08-07 14:10:55 +0000
3+++ imgSeparator.js 2014-08-16 04:46:45 +0000
4@@ -11,7 +11,7 @@
5 for (var i=0; i<image_array.length; i++)
6 {
7 try {
8- image_array[i] = image_array[i].split('src=')[1].split(/"|'/)[1]
9+ image_array[i] = image_array[i].split('src=')[1].split(/"|"/)[1]
10 if (image_array[i].indexOf("//") === 0)
11 image_array[i] = "http:" + image_array[i]
12 }

Subscribers

People subscribed via source and target branches