Merge lp:~vthompson/ubuntu-filemanager-app/module-identifier-1213714 into lp:ubuntu-filemanager-app/plugin
Proposed by
Victor Thompson
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Carlos Jose Mazieri | ||||
| Approved revision: | 34 | ||||
| Merged at revision: | 34 | ||||
| Proposed branch: | lp:~vthompson/ubuntu-filemanager-app/module-identifier-1213714 | ||||
| Merge into: | lp:ubuntu-filemanager-app/plugin | ||||
| Diff against target: |
6 lines (+1/-0) 1 file modified
folderlistmodel/qmldir (+1/-0) |
||||
| To merge this branch: | bzr merge lp:~vthompson/ubuntu-filemanager-app/module-identifier-1213714 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
| Carlos Jose Mazieri | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2013-08-18.
Commit message
Add a module identifier directive to the qmldir file to protect from external registrations.
Description of the change
Add a module identifier directive to the qmldir file to protect from external registrations. Prevents the plugin from producing the following warning message:
Module 'org.nemomobile
To post a comment you must log in.
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:34
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://