Ubuntu File Manager App

Merge lp:~vthompson/ubuntu-filemanager-app/fix-test-issues into lp:ubuntu-filemanager-app

  1. fix-test-issues
  2. Merge into trunk
Proposed by Victor Thompson
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 204
Merged at revision: 205
Proposed branch: lp:~vthompson/ubuntu-filemanager-app/fix-test-issues
Merge into: lp:ubuntu-filemanager-app
Diff against target: 15 lines (+0/-5)
1 file modified
tests/autopilot/filemanager/tests/__init__.py (+0/-5)
To merge this branch: bzr merge lp:~vthompson/ubuntu-filemanager-app/fix-test-issues
Reviewer Review Type Date Requested Status
Brendan Donegan Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Leo Arias (community) Approve
Review via email: mp+223335@code.launchpad.net

Commit message

* Don't turn off OSK
* Fix various test failures

Description of the change

Don't turn off OSK. Doing so 1) violates the nature of testing against the realities of the device, and 2) seems to be causing multiple failures per run of the test suite. I've thus far ran the suite of tests against this branch on my Nexus 4 with the following results:
1: 1 failure (test_copy_file)
2: 0 failures
3: 1 failure (test_copy_file)
4: 0 failures
5: 0 failures

This seems to indicate that test_copy_file also needs some additional hardening. The output for the failed runs can be found here [1].

[1] http://paste.ubuntu.com/7656271/

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

Yes!, I like this.

review: Approve
Revision history for this message
Victor Thompson (vthompson) wrote :

I just ran for a 4th time with all tests passing.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:204
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/254/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/533
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/533/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-utopic-amd64-ci/52

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/254/rebuild

review: Approve (continuous-integration)
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

I tested this too, three times run, no failures. Thanks Victor!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/filemanager/tests/__init__.py'
2--- tests/autopilot/filemanager/tests/__init__.py 2014-06-10 02:34:07 +0000
3+++ tests/autopilot/filemanager/tests/__init__.py 2014-06-17 02:55:09 +0000
4@@ -73,11 +73,6 @@
5 self.pointing_device = Pointer(self.input_device_class.create())
6 super(FileManagerTestCase, self).setUp()
7
8- #turn off the OSK so it doesn't block screen elements
9- if model() != 'Desktop':
10- os.system('stop maliit-server')
11- self.addCleanup(os.system, 'start maliit-server')
12-
13 self.original_file_count = \
14 len([i for i in os.listdir(self.home_dir)
15 if not i.startswith('.')])

Subscribers

People subscribed via source and target branches