Merge lp:~vthompson/ubuntu-filemanager-app/fix-1272160 into lp:ubuntu-filemanager-app
Proposed by
Victor Thompson
Status: | Merged |
---|---|
Approved by: | Michael Spencer |
Approved revision: | 118 |
Merged at revision: | 118 |
Proposed branch: | lp:~vthompson/ubuntu-filemanager-app/fix-1272160 |
Merge into: | lp:ubuntu-filemanager-app |
Diff against target: |
20 lines (+3/-1) 1 file modified
ubuntu-filemanager-app.qml (+3/-1) |
To merge this branch: | bzr merge lp:~vthompson/ubuntu-filemanager-app/fix-1272160 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Spencer | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+204330@code.launchpad.net |
Commit message
* Change app behavior to default to phone mode and transition to tablet mode when app is loaded.
Description of the change
This MP prevents the app from initially showing the side bar in phone mode, thus fixing the bug that caused the item heights to sometimes differ. This introduces a visible transition when in tablet mode (running on desktop, for instance) but that does not cause the item height issue due to the width of the app.
To post a comment you must log in.
PASSED: Continuous integration, rev:118 91.189. 93.70:8080/ job/ubuntu- filemanager- app-ci/ 110/ 91.189. 93.70:8080/ job/generic- mediumtests- trusty/ 894 91.189. 93.70:8080/ job/ubuntu- filemanager- app-raring- amd64-ci/ 110 91.189. 93.70:8080/ job/ubuntu- filemanager- app-saucy- amd64-ci/ 110 91.189. 93.70:8080/ job/ubuntu- filemanager- app-trusty- amd64-ci/ 60
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- filemanager- app-ci/ 110/rebuild
http://