Merge lp:~vthompson/ubuntu-filemanager-app/1312883-initialize-setting into lp:ubuntu-filemanager-app

Proposed by Victor Thompson
Status: Merged
Approved by: Michael Spencer
Approved revision: 165
Merged at revision: 165
Proposed branch: lp:~vthompson/ubuntu-filemanager-app/1312883-initialize-setting
Merge into: lp:ubuntu-filemanager-app
Diff against target: 11 lines (+1/-1)
1 file modified
src/app/qml/ubuntu-filemanager-app.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/ubuntu-filemanager-app/1312883-initialize-setting
Reviewer Review Type Date Requested Status
Michael Spencer Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+217364@code.launchpad.net

Commit message

Default to icon/grid view only when in wide aspect mode

Description of the change

This change defaults the app to list view mode when not in wide aspect mode. To test this you'll need to remove the LocalSettings db on the device by running the following command prior to running the app:

"rm -rf /home/phablet/.local/share/com.ubuntu.filemanager/ubuntu-filemanager-app.db"

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Spencer (ibelieve) wrote :

Thanks for fixing this, the code looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ubuntu-filemanager-app.qml'
2--- src/app/qml/ubuntu-filemanager-app.qml 2014-03-29 09:11:29 +0000
3+++ src/app/qml/ubuntu-filemanager-app.qml 2014-04-27 19:30:46 +0000
4@@ -183,7 +183,7 @@
5
6 function reloadSettings() {
7 //showAdvancedFeatures = getSetting("showAdvancedFeatures", false)
8- viewMethod = getSetting("viewMethod", width > units.gu(40) ? i18n.tr("Icons") : i18n.tr("List"))
9+ viewMethod = getSetting("viewMethod", wideAspect ? i18n.tr("Icons") : i18n.tr("List"))
10 collapsedSidebar = getSetting("collapsedSidebar", false)
11 }
12

Subscribers

People subscribed via source and target branches