Merge lp:~vthompson/ubuntu-clock-app/fix-1366586 into lp:ubuntu-clock-app

Proposed by Victor Thompson
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 93
Merged at revision: 93
Proposed branch: lp:~vthompson/ubuntu-clock-app/fix-1366586
Merge into: lp:ubuntu-clock-app
Diff against target: 11 lines (+1/-0)
1 file modified
app/alarm/AlarmSound.qml (+1/-0)
To merge this branch: bzr merge lp:~vthompson/ubuntu-clock-app/fix-1366586
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Nekhelesh Ramananthan Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+233921@code.launchpad.net

Commit message

Categorize Alarm sound

Description of the change

Media-hub allows categorization of the Audio or MediaPlayer component's sound stream. This allows the system to determine if any sound stream with the categorization of "multimedia", like the music app, needs to be paused while the new stream is playing.

The effect of this change is that the original sound stream (say the music app) is made quiet while the alarm is playing and resumes to normal volume once the alarm preview has stopped.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:93
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~vthompson/ubuntu-clock-app/fix-1366586/+merge/233921/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-clock-app-ci/454/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/263
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/263/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-utopic-amd64-ci/101

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/454/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

code looks good. I just need to test this on the device.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

tested and works as expected! thnx for the patch.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/alarm/AlarmSound.qml'
2--- app/alarm/AlarmSound.qml 2014-08-25 09:59:19 +0000
3+++ app/alarm/AlarmSound.qml 2014-09-09 13:13:45 +0000
4@@ -46,6 +46,7 @@
5
6 Audio {
7 id: previewAlarmSound
8+ audioRole: MediaPlayer.alert
9 }
10
11 Flickable {

Subscribers

People subscribed via source and target branches