Merge lp:~vthompson/ubuntu-calendar-app/update-app-colors into lp:ubuntu-calendar-app

Proposed by Victor Thompson on 2014-04-11
Status: Rejected
Rejected by: David Planella on 2014-06-04
Proposed branch: lp:~vthompson/ubuntu-calendar-app/update-app-colors
Merge into: lp:ubuntu-calendar-app
Diff against target: 74 lines (+8/-7)
5 files modified
AllDayEventComponent.qml (+1/-1)
MonthComponent.qml (+2/-1)
TimeLineBackground.qml (+1/-1)
TimeSeparator.qml (+1/-1)
calendar.qml (+3/-3)
To merge this branch: bzr merge lp:~vthompson/ubuntu-calendar-app/update-app-colors
Reviewer Review Type Date Requested Status
David Planella 2014-04-11 Disapprove on 2014-06-04
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2014-04-11
Ubuntu Calendar Developers 2014-04-16 Pending
Review via email: mp+215348@code.launchpad.net

Commit message

*update app color scheme

Description of the change

This branch is mostly food for thought. How do we want this apps color scheme to look? IMO, I think it should be simplified to align a bit more closely with the branch being proposed here. I think there may be better colors to use, but--again--food for thought.

To post a comment you must log in.
Victor Thompson (vthompson) wrote :

Just a quick download of my thought process. Really, I think the colors that might look nice would be "tooltip" type light yellows and other subtle colors. I chose the orange/peach scheme to be at least a little bit Ubuntu flavored. I'd rather move the scheme closer to something more subtle.

David Planella (dpm) wrote :

Thanks Victor.

I'd like to have some design input/user testing on this one, before we do any changes. It seems the reason we're changing this is because some users found the colour scheme not pleasant. The thing is, we cannot please everyone, and I'd like to avoid a situation where we keep iterating over this while there is so much higher priority tasks before release.

review: Needs Fixing
Mihir Soni (mihirsoni) wrote :

David, did we got any inputs from design team ?

David Planella (dpm) wrote :

We discussed this during the sprint in Malta, got input from design and ended up implementing a new color scheme. I'm thus marking this MP as Rejected, as it got superseded by:

https://code.launchpad.net/~popey/ubuntu-calendar-app/new-colours/+merge/220647

review: Disapprove

Unmerged revisions

240. By Victor Thompson on 2014-04-11

Update app colors

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AllDayEventComponent.qml'
2--- AllDayEventComponent.qml 2014-04-05 06:36:28 +0000
3+++ AllDayEventComponent.qml 2014-04-11 04:33:32 +0000
4@@ -16,7 +16,7 @@
5
6 height: units.gu(6)
7 width: parent.width
8- color: "#105040"
9+ color: "#DD4814"
10
11 function getAllDayEvents(startDate, endDate) {
12 var map = {};
13
14=== modified file 'MonthComponent.qml'
15--- MonthComponent.qml 2014-03-01 02:39:42 +0000
16+++ MonthComponent.qml 2014-04-11 04:33:32 +0000
17@@ -58,6 +58,7 @@
18 id: ubuntuShape
19
20 anchors.fill: parent
21+ color: "#FFC793"
22 radius: "medium"
23
24 Column{
25@@ -207,7 +208,7 @@
26 text: day.toUpperCase();
27 horizontalAlignment: Text.AlignHCenter
28 fontSize: root.dayLabelFontSize
29- color: "#AEA79F"
30+ color: "#FFFFFF"
31 }
32 }
33
34
35=== modified file 'TimeLineBackground.qml'
36--- TimeLineBackground.qml 2013-09-04 13:37:10 +0000
37+++ TimeLineBackground.qml 2014-04-11 04:33:32 +0000
38@@ -9,7 +9,7 @@
39 delegate: Rectangle {
40 width: parent.width
41 height: units.gu(10)
42- color: ( index % 2 == 0) ? "#4c875b" : "#86c07f"
43+ color: ( index % 2 == 0) ? "#FFC793" : "#FF9561"
44 Label{
45 id: timeLabel
46
47
48=== modified file 'TimeSeparator.qml'
49--- TimeSeparator.qml 2013-06-01 11:55:55 +0000
50+++ TimeSeparator.qml 2014-04-11 04:33:32 +0000
51@@ -3,5 +3,5 @@
52 Rectangle {
53 id: separator
54 height: units.gu(0.5)
55- color: "#c94212"
56+ color: "#DD4814"
57 }
58
59=== modified file 'calendar.qml'
60--- calendar.qml 2014-04-05 08:53:53 +0000
61+++ calendar.qml 2014-04-11 04:33:32 +0000
62@@ -55,9 +55,9 @@
63 focus: true
64 Keys.forwardTo: [yearView,monthView,weekView,dayView,pageStack.currentPage,tabPage]
65
66- headerColor: "#266249"
67- backgroundColor: "#478158"
68- footerColor: "#478158"
69+ headerColor: "#FFFFFF"
70+ backgroundColor: "#FFFFFF"
71+ footerColor: "#FFFFFF"
72 anchorToKeyboard: true
73
74 PageStack {

Subscribers

People subscribed via source and target branches

to status/vote changes: