Merge lp:~vthompson/ubuntu-calendar-app/revert-commit-247 into lp:ubuntu-calendar-app

Proposed by Victor Thompson
Status: Merged
Approved by: Kunal Parmar
Approved revision: 254
Merged at revision: 256
Proposed branch: lp:~vthompson/ubuntu-calendar-app/revert-commit-247
Merge into: lp:ubuntu-calendar-app
Diff against target: 22 lines (+0/-6)
1 file modified
calendar.qml (+0/-6)
To merge this branch: bzr merge lp:~vthompson/ubuntu-calendar-app/revert-commit-247
Reviewer Review Type Date Requested Status
Kunal Parmar Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+217316@code.launchpad.net

Commit message

Revert commit #247

Description of the change

This branch reverts commit #247. The capability required to display the window title has landed. I'm not even sure the MP in the code commentary was the correct one.

I'd also like to add that fixing this needs to be done quickly if any testing is to be done on the device. Pushing the Calendar app to the click store should also be held hostage until this is fixed, because the app is effectively broken.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

Works fine, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'calendar.qml'
2--- calendar.qml 2014-04-19 21:22:21 +0000
3+++ calendar.qml 2014-04-26 00:09:59 +0000
4@@ -1,18 +1,12 @@
5 import QtQuick 2.0
6 import Ubuntu.Components 0.1
7 import Ubuntu.Components.Popups 0.1
8-import QtQuick.Window 2.0
9
10 import "dateExt.js" as DateExt
11
12 MainView {
13 id: mainView
14
15- // Work-around until this branch lands:
16- // https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/optIn-tabsDrawer/+merge/212496
17- property bool windowActive: typeof window != 'undefined'
18- onWindowActiveChanged: window.title = i18n.tr("Calendar")
19-
20 // Argument during startup
21 Arguments {
22 id: args;

Subscribers

People subscribed via source and target branches

to status/vote changes: