Merge lp:~vthompson/ubuntu-calendar-app/fixes-1247192 into lp:ubuntu-calendar-app

Proposed by Victor Thompson on 2013-11-02
Status: Rejected
Rejected by: Kunal Parmar on 2014-04-10
Proposed branch: lp:~vthompson/ubuntu-calendar-app/fixes-1247192
Merge into: lp:ubuntu-calendar-app
Diff against target: 11 lines (+1/-0)
1 file modified
YearView.qml (+1/-0)
To merge this branch: bzr merge lp:~vthompson/ubuntu-calendar-app/fixes-1247192
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2014-04-03
Kunal Parmar 2013-11-02 Needs Fixing on 2013-12-03
Review via email: mp+193683@code.launchpad.net

Commit message

* Make only current year's GridView visible

Description of the change

* Make only current year's GridView visible

To post a comment you must log in.
166. By Victor Thompson on 2013-11-04

Make visible if dragging the PathView

Kunal Parmar (pkunal-parmar) wrote :

This is causing some strage behaviour. While dragging it seems fine, but when you stop dragging you can see empty screen for some time.

Same happens while you are flicking the view, you can see flicker as yearview's visibility changes .

review: Needs Fixing
167. By Victor Thompson on 2013-12-08

merge trunk

There's a noticeable flicker when moving from one year to the next as Kunal says.. Here's a video. http://youtu.be/pCcCTRSbw1I

168. By Victor Thompson on 2014-04-03

Make all delegates visible while path is moving

169. By Victor Thompson on 2014-04-03

Merge of trunk

Victor Thompson (vthompson) wrote :

Modified this so while the items on the path are still moving they are visible. This prevents the flicker and hopefully satisfies what Leo wants.

170. By Victor Thompson on 2014-04-03

Use index suggestion

Kunal Parmar (pkunal-parmar) wrote :

hello, I marked bug as invalid, as I making all view visible is intended behavior.

But if in Autopilot if you need to check if view is current one or not you can use isCurrentItem property.

property bool isCurrentItem: index == root.currentIndex

So I think this MR is not required

Unmerged revisions

170. By Victor Thompson on 2014-04-03

Use index suggestion

169. By Victor Thompson on 2014-04-03

Merge of trunk

168. By Victor Thompson on 2014-04-03

Make all delegates visible while path is moving

167. By Victor Thompson on 2013-12-08

merge trunk

166. By Victor Thompson on 2013-11-04

Make visible if dragging the PathView

165. By Victor Thompson on 2013-11-02

Set previous and next years to be not visible.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'YearView.qml'
2--- YearView.qml 2014-03-22 03:07:26 +0000
3+++ YearView.qml 2014-04-03 14:46:29 +0000
4@@ -23,6 +23,7 @@
5 delegate: GridView{
6 id: yearView
7 clip: true
8+ visible: index == root.currentIndex || root.moving
9
10 property bool isCurrentItem: index == root.currentIndex
11 property int year: (root.currentYear + root.indexType(index))

Subscribers

People subscribed via source and target branches

to status/vote changes: