Merge lp:~vthompson/ubuntu-calendar-app/fixes-1247191 into lp:ubuntu-calendar-app

[Victor Thompson]

* Only the current year's GridView have focus as True

* Only the current year's GridView have focus as True

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:165
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/183/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/183
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/183
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/17

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/183/rebuild

review: Needs Fixing (continuous-integration)

[Kunal Parmar (pkunal-parmar)]

This change is causing some side effect, changes will hide previous and next year, which will leave blank space while we are scrolling years horizontally. I am not sure if we want this behavior.

Please see following screenshot which shows what I am talking about

Following screenshot contains following changes, which hides next year when we are scrolling horizontally, which leaves blank space
http://ubuntuone.com/0JThJJxHIceoAtlO5kS7ep

Originally it was looking like following.
http://ubuntuone.com/6GvVlwjiPu2B4jcwJygGh3

review: Needs Fixing

[Kunal Parmar (pkunal-parmar)]

My Opinion is that #1247191 is not a bug, it is expected behavior for years horizontal scrolling.

[Victor Thompson (vthompson)]

Kunal,

Are you sure you are not speaking of the MR for lp:1247192 [1]? The merge you are commenting on does not change the scrolling behavior.

[1] lp:~vthompson/ubuntu-calendar-app/fixes-1247192

[lp:~vthompson/ubuntu-calendar-app/fixes-1247191]

166. By Victor Thompson on 2013-11-04

Give focus if dragging the PathView

[Victor Thompson (vthompson)]

Kunal,

I believe I have addressed your concerns on this branch as well as the other one.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:166
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/188/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/188
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/188
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/22

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/188/rebuild

review: Needs Fixing (continuous-integration)

[Kunal Parmar (pkunal-parmar)]

> Kunal,
>
> Are you sure you are not speaking of the MR for lp:1247192 [1]? The merge you
> are commenting on does not change the scrolling behavior.
>
> [1] lp:~vthompson/ubuntu-calendar-app/fixes-1247192

Yes, I think I was confused with two mr.

[Kunal Parmar (pkunal-parmar)]

I checked, this changes does not affect current working of YearView. If this changes help in improving test case then I am fine with the changes.

review: Approve

[lp:~vthompson/ubuntu-calendar-app/fixes-1247191]

167. By Victor Thompson on 2013-12-08

merge trunk

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:167
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/224/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/361
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/224
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/224
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/58

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/224/rebuild

review: Approve (continuous-integration)

[Olivier Tilloy (osomon)]

This change doesn’t make sense to me: in PathViewBase, indexType(…) returns 1 for the next year, not for the current one.

On top of that, the root.dragging condition means that whenever the user is dragging, all three delegates will be focused at the same time. How about:

    focus: index == root.currentIndex

review: Needs Fixing

[lp:~vthompson/ubuntu-calendar-app/fixes-1247191]

168. By Victor Thompson on 2014-04-03

Use index suggestion

169. By Victor Thompson on 2014-04-03

Do not focus all items while path is moving

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:168
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/360/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1952
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/360
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/360
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/194

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/360/rebuild

review: Approve (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:169
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/362/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1954
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/362
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/362
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/196

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/362/rebuild

review: Approve (continuous-integration)

=== modified file 'YearView.qml'
--- YearView.qml	2014-03-22 03:07:26 +0000
+++ YearView.qml	2014-04-03 14:52:15 +0000
@@ -23,6 +23,7 @@
     delegate: GridView{
         id: yearView
         clip: true
+        focus: index == root.currentIndex
 
         property bool isCurrentItem: index == root.currentIndex
         property int year: (root.currentYear + root.indexType(index))