Merge lp:~vthompson/music-app/workaround-1407840-1409186 into lp:music-app/remix

[Victor Thompson]

Workaround for lp:1407840 and lp:1409186. The Multi-select Delete action needs to be refactored.

Workaround for lp:1407840 and lp:1409186. The Multi-select Delete action needs to be refactored as it can fail when removing multiple items and can cause the app to become unresponsive when removing many items.

DO NOT LAND UNLESS THE REFACTORING OF THIS FUNCTIONALITY CAN NOT BE ACHIEVED BY JANUARY 12TH WHEN THE APP IS TO BE HANDED OFF TO QA.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:774
http://91.189.93.70:8080/job/music-app-ci/1193/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/609
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/609/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/45

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1193/rebuild

review: Approve (continuous-integration)

[lp:~vthompson/music-app/workaround-1407840-1409186]

775. By Victor Thompson on 2015-01-10

update copyright

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:775
http://91.189.93.70:8080/job/music-app-ci/1194/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/610
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/610/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/46

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1194/rebuild

review: Approve (continuous-integration)

[Victor Thompson (vthompson)]

Andrew has a refactor of the Multi-select delete action that works well. This MP is not needed.

review: Disapprove

Unmerged revisions

775. By Victor Thompson on 2015-01-10

update copyright

774. By Victor Thompson on 2015-01-10

Work around for lp:1407840 and lp:1409186. The Multi-select Delete action needs to be refactored.

=== modified file 'MusicNowPlaying.qml'
--- MusicNowPlaying.qml	2015-01-08 00:47:52 +0000
+++ MusicNowPlaying.qml	2015-01-10 03:32:23 +0000
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013, 2014
+ * Copyright (C) 2013-2015
  *      Andrew Hayzen <[e-mail]>
  *      Daniel Holm <[e-mail]>
  *      Victor Thompson <[e-mail]>
@@ -166,19 +166,24 @@
 
                         queueListLoader.item.closeSelection()
                     }
-                },
-                Action {
-                    enabled: queueListLoader.item.selectedItems.length > 0
-                    iconName: "delete"
-                    text: i18n.tr("Delete")
-                    onTriggered: {
-                        for (var i=0; i < queueListLoader.item.selectedItems.length; i++) {
-                            removeQueue(queueListLoader.item.selectedItems[i])
-                        }
-
-                        queueListLoader.item.closeSelection()
-                    }
                 }
+                // FIXME: Workaround for http://pad.lv/1407840 and http://pad.lv/1409186. Currently,
+                //        removing many items from the queue using the Multi-select Delete action will
+                //        fail after 11 or so items (number seems to vary). Also, in general the
+                //        Multi-select Delete action is slow and can cause the app to become unresponsive.
+                //        Therefore, the Multi-select Delete action needs to be redesigned.
+                //Action {
+                //    enabled: queueListLoader.item.selectedItems.length > 0
+                //    iconName: "delete"
+                //    text: i18n.tr("Delete")
+                //    onTriggered: {
+                //        for (var i=0; i < queueListLoader.item.selectedItems.length; i++) {
+                //            removeQueue(queueListLoader.item.selectedItems[i])
+                //        }
+
+                //        queueListLoader.item.closeSelection()
+                //    }
+                //}
             ]
             PropertyChanges {
                 target: nowPlaying.head