Merge lp:~vthompson/music-app/use-sdk-back-button-take2 into lp:music-app/trusty

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 453
Merged at revision: 451
Proposed branch: lp:~vthompson/music-app/use-sdk-back-button-take2
Merge into: lp:music-app/trusty
Diff against target: 32 lines (+3/-1)
2 files modified
MusicNowPlaying.qml (+2/-1)
music-app.qml (+1/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/use-sdk-back-button-take2
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+218534@code.launchpad.net

Commit message

Support new SDK back button and tab drawer

Description of the change

Support new SDK back button and tab drawer

To post a comment you must log in.
452. By Victor Thompson

remove debug

453. By Victor Thompson

Adjust topMargin

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Nice work and making it backwards compatible :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicNowPlaying.qml'
2--- MusicNowPlaying.qml 2014-04-24 22:58:26 +0000
3+++ MusicNowPlaying.qml 2014-05-07 00:41:02 +0000
4@@ -98,7 +98,7 @@
5 objectName: "queuelist"
6 anchors.fill: parent
7 anchors.bottomMargin: musicToolbar.mouseAreaOffset + musicToolbar.minimizedHeight
8- anchors.topMargin: nowPlayingBackButton.height
9+ anchors.topMargin: header.useDeprecatedToolbar === undefined ? nowPlayingBackButton.height : 0
10 spacing: units.gu(1)
11 delegate: queueDelegate
12 model: trackQueue.model
13@@ -810,6 +810,7 @@
14 // TODO: Remove back button once lp:1256424 is fixed (button will be in header)
15 Rectangle {
16 id: nowPlayingBackButton
17+ visible: header.useDeprecatedToolbar === undefined
18 anchors {
19 left: parent.left
20 right: parent.right
21
22=== modified file 'music-app.qml'
23--- music-app.qml 2014-05-04 04:37:52 +0000
24+++ music-app.qml 2014-05-07 00:41:02 +0000
25@@ -38,6 +38,7 @@
26 objectName: "music"
27 applicationName: "com.ubuntu.music"
28 id: mainView
29+ useDeprecatedToolbar: false
30
31 // Use toolbar color for header
32 headerColor: styleMusic.toolbar.fullBackgroundColor

Subscribers

People subscribed via source and target branches

to status/vote changes: