Merge lp:~vthompson/music-app/use-media-keys into lp:music-app/remix

Proposed by Victor Thompson
Status: Work in progress
Proposed branch: lp:~vthompson/music-app/use-media-keys
Merge into: lp:music-app/remix
Diff against target: 22 lines (+13/-0)
1 file modified
music-app.qml (+13/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/use-media-keys
Reviewer Review Type Date Requested Status
Bartosz Kosiorek (community) Needs Information
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+254468@code.launchpad.net

Commit message

* Add media keys

Description of the change

* Add media keys

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Hello Victor.

Do you know why it wasn't merged yet?

review: Needs Information
Revision history for this message
Victor Thompson (vthompson) wrote :

I don't believe the solution is working. I don't it works using either the media keys on the keyboard or the bluetooth controls, which we believed to be the same at the time this fix was written.

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

When [0] lands, I believe this will be fixed upstream to us as media-hub/indicator-sound will then be able to control the next/pre/play/pause and capture the events when we are suspended.

0 - https://code.launchpad.net/~music-app-dev/music-app/media-hub-bg-playlists-rework

Unmerged revisions

851. By Victor Thompson

* Add media keys

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'music-app.qml'
2--- music-app.qml 2015-03-24 02:17:30 +0000
3+++ music-app.qml 2015-03-27 22:21:05 +0000
4@@ -118,6 +118,19 @@
5 player.shuffle = !player.shuffle
6 break;
7 }
8+ } else {
9+ switch (event.key) {
10+ case Qt.Key_MediaPlay: // Play Toggle playing state
11+ case Qt.Key_MediaPause: // Pause Toggle playing state
12+ player.toggle();
13+ break;
14+ case Qt.Key_MediaPrev: // Prev Previous Song
15+ player.previousSong(true);
16+ break;
17+ case Qt.Key_MediaNext: // Next Next Song
18+ player.nextSong(true, true);
19+ break;
20+ }
21 }
22 }
23

Subscribers

People subscribed via source and target branches