Merge lp:~vthompson/music-app/shorten-empty-queue-msg-1357625 into lp:music-app/trusty

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 575
Merged at revision: 578
Proposed branch: lp:~vthompson/music-app/shorten-empty-queue-msg-1357625
Merge into: lp:music-app/trusty
Diff against target: 80 lines (+18/-22)
2 files modified
MusicToolbar.qml (+9/-13)
po/com.ubuntu.music.pot (+9/-9)
To merge this branch: bzr merge lp:~vthompson/music-app/shorten-empty-queue-msg-1357625
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+231091@code.launchpad.net

Commit message

* Fix empty queue message length
* Wrap text for empty queue message

Description of the change

This MP changes the empty queue message to simply "Tap play to shuffle music". It also allows this text to wrap to 2 lines.

To post a comment you must log in.
Revision history for this message
Victor Thompson (vthompson) wrote :

This is what my assumed Spanish translation looks like: http://i.imgur.com/V8mXrTm.png

*Note the translation could be bad, but it shows the text wrapping to 2 lines.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Looks good to me, assuming the Spanish translation is as you have assumed :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicToolbar.qml'
2--- MusicToolbar.qml 2014-08-13 20:57:09 +0000
3+++ MusicToolbar.qml 2014-08-16 17:22:25 +0000
4@@ -750,21 +750,17 @@
5
6 Label {
7 id: noSongsInQueueLabel
8- anchors.left: parent.left
9- anchors.margins: units.gu(1)
10- anchors.top: parent.top
11+ anchors {
12+ left: parent.left
13+ right: disabledPlayerControlsPlayButton.left
14+ margins: units.gu(1)
15+ top: parent.top
16+ }
17 color: styleMusic.playerControls.labelColor
18- text: i18n.tr("No songs queued")
19+ text: i18n.tr("Tap play to shuffle music")
20 fontSize: "large"
21- }
22-
23- Label {
24- id: tabToStartPlayingLabel
25- color: styleMusic.playerControls.labelColor
26- anchors.left: parent.left
27- anchors.margins: units.gu(1)
28- anchors.top: noSongsInQueueLabel.bottom
29- text: i18n.tr("Tap play or any item to start")
30+ wrapMode: Text.WordWrap
31+ maximumLineCount: 2
32 }
33
34 Rectangle {
35
36=== modified file 'po/com.ubuntu.music.pot'
37--- po/com.ubuntu.music.pot 2014-08-16 03:11:50 +0000
38+++ po/com.ubuntu.music.pot 2014-08-16 17:22:25 +0000
39@@ -8,7 +8,7 @@
40 msgstr ""
41 "Project-Id-Version: music-app\n"
42 "Report-Msgid-Bugs-To: \n"
43-"POT-Creation-Date: 2014-08-15 22:10-0500\n"
44+"POT-Creation-Date: 2014-08-16 12:07-0500\n"
45 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
46 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
47 "Language-Team: LANGUAGE <LL@li.org>\n"
48@@ -125,7 +125,10 @@
49 msgid "Cancel"
50 msgstr ""
51
52-#: ../MusicPlaylists.qml:161 ../MusicStart.qml:202
53+#: ../MusicPlaylists.qml:158 ../MusicPlaylists.qml:161 ../MusicStart.qml:120
54+#: ../MusicStart.qml:202 ../common/SongsPage.qml:165
55+#: ../common/SongsPage.qml:223 ../common/SongsPage.qml:225
56+#: ../common/SongsPage.qml:243
57 msgid "Playlist"
58 msgstr ""
59
60@@ -237,16 +240,13 @@
61 msgid "Genres"
62 msgstr ""
63
64-#: ../MusicStart.qml:312
65+#: ../MusicStart.qml:310 ../MusicStart.qml:312 ../common/SongsPage.qml:122
66+#: ../common/SongsPage.qml:161 ../common/SongsPage.qml:239
67 msgid "Genre"
68 msgstr ""
69
70-#: ../MusicToolbar.qml:757
71-msgid "No songs queued"
72-msgstr ""
73-
74-#: ../MusicToolbar.qml:767
75-msgid "Tap play or any item to start"
76+#: ../MusicToolbar.qml:760
77+msgid "Tap play to shuffle music"
78 msgstr ""
79
80 #: ../MusicTracks.qml:35

Subscribers

People subscribed via source and target branches

to status/vote changes: