Ubuntu Music App

Merge lp:~vthompson/music-app/remove-white-error-labels-1353173 into lp:music-app/trusty

  1. remove-white-error-labels-1353173
  2. Merge into trusty
Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 553
Merged at revision: 556
Proposed branch: lp:~vthompson/music-app/remove-white-error-labels-1353173
Merge into: lp:music-app/trusty
Diff against target: 86 lines (+10/-6)
3 files modified
MusicPlaylists.qml (+5/-3)
Style.qml (+2/-1)
music-app.qml (+3/-2)
To merge this branch: bzr merge lp:~vthompson/music-app/remove-white-error-labels-1353173
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+229713@code.launchpad.net

Commit message

* Make dialog error text red instead of white
* Make confirm dialog button orange

Description of the change

Make dialog error text red instead of white because a recent change to the ubuntu-ui-toolkit (see bug) has made the dialog boxes white, which is the same color the error text being used currently is. I suggest we use a red font color.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:550
http://91.189.93.70:8080/job/music-app-ci/976/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1302
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1302/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/200

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/976/rebuild

review: Needs Fixing (continuous-integration)
lp:~vthompson/music-app/remove-white-error-labels-1353173 updated
552. By Victor Thompson

merge of trunk

553. By Victor Thompson

* Make dialog error text red instead of white
* Make confirm dialog button orange

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:551
http://91.189.93.70:8080/job/music-app-ci/978/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1304
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1304/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/202

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/978/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:553
http://91.189.93.70:8080/job/music-app-ci/979/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1305
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1305/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/203

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/979/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicPlaylists.qml'
2--- MusicPlaylists.qml 2014-08-06 02:13:53 +0000
3+++ MusicPlaylists.qml 2014-08-06 02:26:47 +0000
4@@ -71,12 +71,13 @@
5 }
6 Label {
7 id: editplaylistoutput
8- color: "white"
9+ color: "red"
10 visible: false
11 }
12
13 Button {
14 text: i18n.tr("Change")
15+ color: styleMusic.dialog.confirmButtonColor
16 onClicked: {
17 editplaylistoutput.visible = true
18
19@@ -103,7 +104,7 @@
20 }
21 Button {
22 text: i18n.tr("Cancel")
23- color: styleMusic.dialog.buttonColor
24+ color: styleMusic.dialog.cancelButtonColor
25 onClicked: PopupUtils.close(dialogueEditPlaylist)
26 }
27 }
28@@ -120,6 +121,7 @@
29
30 Button {
31 text: i18n.tr("Remove")
32+ color: styleMusic.dialog.confirmButtonColor
33 onClicked: {
34 // removing playlist
35 Playlists.removePlaylist(oldPlaylistName)
36@@ -131,7 +133,7 @@
37 }
38 Button {
39 text: i18n.tr("Cancel")
40- color: styleMusic.dialog.buttonColor
41+ color: styleMusic.dialog.cancelButtonColor
42 onClicked: PopupUtils.close(dialogueRemovePlaylist)
43 }
44 }
45
46=== modified file 'Style.qml'
47--- Style.qml 2014-08-06 02:13:53 +0000
48+++ Style.qml 2014-08-06 02:26:47 +0000
49@@ -46,7 +46,8 @@
50 }
51
52 property QtObject dialog: QtObject {
53- property color buttonColor: UbuntuColors.coolGrey;
54+ property color confirmButtonColor: UbuntuColors.orange;
55+ property color cancelButtonColor: UbuntuColors.coolGrey;
56 property color normalTextFieldColor: common.white
57 }
58
59
60=== modified file 'music-app.qml'
61--- music-app.qml 2014-08-06 02:13:53 +0000
62+++ music-app.qml 2014-08-06 02:26:47 +0000
63@@ -707,12 +707,13 @@
64 }
65 Label {
66 id: newplaylistoutput
67- color: "white"
68+ color: "red"
69 visible: false // should only be visible when an error is made.
70 }
71
72 Button {
73 text: i18n.tr("Create")
74+ color: styleMusic.dialog.confirmButtonColor
75 objectName: "newPlaylistDialog_createButton"
76 onClicked: {
77 newplaylistoutput.visible = false // make sure its hidden now if there was an error last time
78@@ -739,7 +740,7 @@
79
80 Button {
81 text: i18n.tr("Cancel")
82- color: styleMusic.dialog.buttonColor
83+ color: styleMusic.dialog.cancelButtonColor
84 onClicked: PopupUtils.close(dialogueNewPlaylist)
85 }
86 }

Subscribers

People subscribed via source and target branches

to status/vote changes: