Merge lp:~vthompson/music-app/remove-qtpowerd into lp:music-app/trusty
Status: | Merged |
---|---|
Approved by: | David Planella |
Approved revision: | 378 |
Merged at revision: | 396 |
Proposed branch: | lp:~vthompson/music-app/remove-qtpowerd |
Merge into: | lp:music-app/trusty |
Diff against target: |
52 lines (+0/-14) 3 files modified
debian/control (+0/-1) music-app.qml (+0/-10) plugins.json (+0/-3) |
To merge this branch: | bzr merge lp:~vthompson/music-app/remove-qtpowerd |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alan Pope πΊπ§π± π¦ (community) | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+210944@code.launchpad.net |
Commit message
Remove QtPowerd
Description of the change
This is a proposal to remove QtPowerd since it is not needed to keep the music-app alive due to the lifecycle exceptions it currently has (which will be removed soon). This means that the dependency upon QtPowerd could have been removed quite some time ago.
To test, I pushed the updated QML files and plugins.json file to /opt/click.
One thing to note is that currently if the user has Qt5.2 (might be due to other changes in the landing006 PPA) on the device, both before and after this change music will stop when a track ends AND the device's screen is off. If the user's screen is simply turned back on the next song will start playing. I'm not sure what the issue is here--but it is unrelated to this change.
PASSED: Continuous integration, rev:378 91.189. 93.70:8080/ job/music- app-ci/ 642/ 91.189. 93.70:8080/ job/generic- mediumtests- trusty/ 1740 91.189. 93.70:8080/ job/music- app-raring- amd64-ci/ 642 91.189. 93.70:8080/ job/music- app-saucy- amd64-ci/ 644 91.189. 93.70:8080/ job/music- app-trusty- amd64-ci/ 363
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/music- app-ci/ 642/rebuild
http://