Merge lp:~vthompson/music-app/remix-use-art-property-in-playlists into lp:music-app/remix

[Victor Thompson]

* Use art property for playlists

Use art property for playlists. Currently we use the album/artist lookup, but that isn't always the desired method. If the album/artist isn't found via lookup, surely the embedded cover art should be used. Matter of fact, the embedded cover art is actually the preferred source. Thus, the app shouldn't default to the album/artist lookup. This is probably the last place we have this done incorrectly (I hope).

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:730
http://91.189.93.70:8080/job/music-app-remix-ci/237/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/108
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/108/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-vivid-amd64-ci/12

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/237/rebuild

review: Approve (continuous-integration)

[Andrew Hayzen (ahayzen)]

I think you need to modify the find() function to respect the new changes of row?

review: Needs Fixing

[lp:~vthompson/music-app/remix-use-art-property-in-playlists]

731. By Victor Thompson on 2014-11-10

Update find() utility function

[Victor Thompson (vthompson)]

Right, right. Thanks, this has been updated.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:731
http://91.189.93.70:8080/job/music-app-remix-ci/238/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/112
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/112/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-vivid-amd64-ci/13

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/238/rebuild

review: Approve (continuous-integration)

[lp:~vthompson/music-app/remix-use-art-property-in-playlists]

732. By Victor Thompson on 2014-11-10

Since the art property is always unique, still populate the author and album

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:732
http://91.189.93.70:8080/job/music-app-remix-ci/239/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/113
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/113/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-vivid-amd64-ci/14

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/239/rebuild

review: Approve (continuous-integration)

[Andrew Hayzen (ahayzen)]

LGTM :) Hopefully the last occurrence of not using art lol ;)

review: Approve

=== modified file 'playlists.js'
--- playlists.js	2014-10-29 00:43:56 +0000
+++ playlists.js	2014-11-10 03:03:38 +0000
@@ -262,7 +262,8 @@
                  && i < (max || rs.rows.length); i++) {
                 var row = {
                     author: rs.rows.item(i).author,
-                    album: rs.rows.item(i).album
+                    album: rs.rows.item(i).album,
+                    art: musicStore.lookup(rs.rows.item(i).filename).art
                 }
 
                 if (find(res, row) === null) {