Merge lp:~vthompson/music-app/remix-update-CoverGrid-sourceSize into lp:music-app/remix

[Victor Thompson]

* Set the sourceSize of the CoverGrid to the Thumbnailer's 'xlarge' default.

This sets the sourceSize in the CoverGrid to that of the Thumbnailer's largest (xlarge) thumbnail, which is 512x512 pixels. Previously rescaling these to 330 and 165 (see bug report) was causing the thumbnails to load very slowly.

[lp:~vthompson/music-app/remix-update-CoverGrid-sourceSize]

732. By Victor Thompson on 2014-11-11

* Update BlurredBackground

[Andrew Hayzen (ahayzen)]

Awesome find LGTM :)

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:731
http://91.189.93.70:8080/job/music-app-remix-ci/242/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/131
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/131/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-vivid-amd64-ci/17

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/242/rebuild

review: Approve (continuous-integration)

=== modified file 'common/BlurredBackground.qml'
--- common/BlurredBackground.qml	2014-10-21 20:11:35 +0000
+++ common/BlurredBackground.qml	2014-11-11 02:46:56 +0000
@@ -41,11 +41,21 @@
         anchors.horizontalCenter: parent.horizontalCenter
         anchors.verticalCenter: parent.verticalCenter
         asynchronous: true
-        source: art // this has to be fixed for the default cover art to work - cant find in this dir
         fillMode: Image.PreserveAspectCrop
         height: parent.height
+        source: art // this has to be fixed for the default cover art to work - cant find in this dir
+
+        // TODO: This should be investigated once http://pad.lv/1391368
+        //       is resolved. Once it is, these can either be set to
+        //       "height" and "width" or a property exposed via the
+        //       SDK or Thumbnailer to avoid a regression caused by
+        //       these hardcoded values changing in the Thumbnailer.
+        //       512 is size of the "xlarge" thumbnails in pixels.
+        sourceSize.height: 512
+        sourceSize.width: 512
+
+        visible: false
         width: Math.max(parent.height, parent.width)
-        visible: false
     }
 
     // the blur

=== modified file 'common/CoverGrid.qml'
--- common/CoverGrid.qml	2014-10-21 20:11:35 +0000
+++ common/CoverGrid.qml	2014-11-11 02:46:56 +0000
@@ -61,8 +61,15 @@
                            ? coverGrid.covers[index].art
                            : "image://albumart/artist=" + coverGrid.covers[index].author + "&album=" + coverGrid.covers[index].album)
                         : ""
-                sourceSize.height: height
-                sourceSize.width: width
+
+                // TODO: This should be investigated once http://pad.lv/1391368
+                //       is resolved. Once it is, these can either be set to
+                //       "height" and "width" or a property exposed via the
+                //       SDK or Thumbnailer to avoid a regression caused by
+                //       these hardcoded values changing in the Thumbnailer.
+                //       512 is size of the "xlarge" thumbnails in pixels.
+                sourceSize.height: 512
+                sourceSize.width: 512
 
                 onStatusChanged: {
                     if (status === Image.Error) {