Merge lp:~vthompson/music-app/remix-now-playing-main-view-blue-slider into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 666
Merged at revision: 652
Proposed branch: lp:~vthompson/music-app/remix-now-playing-main-view-blue-slider
Merge into: lp:music-app/remix
Prerequisite: lp:~vthompson/music-app/remix-now-playing-main-view
Diff against target: 14 lines (+4/-0)
1 file modified
MusicNowPlaying.qml (+4/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/remix-now-playing-main-view-blue-slider
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+237170@code.launchpad.net

This proposal supersedes a proposal from 2014-10-04.

Commit message

* Make the Ubuntu Slider leftColor UbuntuColors.blue

Description of the change

This change makes the Ubuntu Slider leftColor UbuntuColors.blue for use in the Now Playing full view.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, as discussed we'll use this for now until a 'better' solution is found.

It seems there is a SliderStyle component in QML [0] but that is not installed, the SDK seems to create their own StyleItem located (on a x86_64 system) [1]

0 - http://qt-project.org/doc/qt-5/qml-qtquick-controls-styles-sliderstyle.html
1 - /usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/Themes/Ambiance/SliderStyle.qml

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicNowPlaying.qml'
2--- MusicNowPlaying.qml 2014-10-04 17:07:58 +0000
3+++ MusicNowPlaying.qml 2014-10-04 17:07:58 +0000
4@@ -204,6 +204,10 @@
5 }
6 }
7
8+ Component.onCompleted: {
9+ Theme.palette.selected.foreground = UbuntuColors.blue
10+ }
11+
12 onPressedChanged: {
13 seeking = pressed
14 if (!pressed) {

Subscribers

People subscribed via source and target branches