Merge lp:~vthompson/music-app/remix-music-splash into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 650
Merged at revision: 650
Proposed branch: lp:~vthompson/music-app/remix-music-splash
Merge into: lp:music-app/remix
Diff against target: 11 lines (+3/-0)
1 file modified
com.ubuntu.music_music.desktop.in.in (+3/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/remix-music-splash
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+237193@code.launchpad.net

Commit message

Used new desktop entries to show a fake application page during the startup.

Description of the change

Used new desktop entries to show a fake application page during the startup.

To test I had to manually copy the desktop file that was deployed to ~/.local/share/applications:

cp /opt/click.ubuntu.com/.click/users/phablet/com.ubuntu.music/com.ubuntu.music_music.desktop /home/phablet/.local/share/applications/com.ubuntu.music_music_1.3.649.desktop

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, I wonder if we should remove the "Loading..." or change it so it appears the same as the SDK loading in the future?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'com.ubuntu.music_music.desktop.in.in'
2--- com.ubuntu.music_music.desktop.in.in 2014-07-21 14:49:14 +0000
3+++ com.ubuntu.music_music.desktop.in.in 2014-10-05 20:20:33 +0000
4@@ -9,4 +9,7 @@
5 StartupNotify=true
6 X-Ubuntu-Touch=true
7 X-Ubuntu-Single-Instance=true
8+X-Ubuntu-Splash-Show-Header=true
9+_X-Ubuntu-Splash-Title=Music
10+_X-Ubuntu-Splash-Color=#1e1e23
11 X-Ubuntu-Default-Department-ID=sound-video

Subscribers

People subscribed via source and target branches