Merge lp:~vthompson/music-app/remix-improve-AlbumsPage-first-load into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 677
Merged at revision: 677
Proposed branch: lp:~vthompson/music-app/remix-improve-AlbumsPage-first-load
Merge into: lp:music-app/remix
Diff against target: 12 lines (+1/-1)
1 file modified
common/AlbumsPage.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/music-app/remix-improve-AlbumsPage-first-load
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+238910@code.launchpad.net

Commit message

Force AlbumsPage's SongsModel to filter upon startup

Description of the change

This small change causes the SongsModel within the AlbumsPage to filter upon startup. This prevents the delay currently seen when the user first selects and Artist from the Artists tab.

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Nice hack :) LGTM

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/AlbumsPage.qml'
2--- common/AlbumsPage.qml 2014-10-16 23:36:00 +0000
3+++ common/AlbumsPage.qml 2014-10-20 15:38:19 +0000
4@@ -31,7 +31,7 @@
5 objectName: "albumsArtistPage"
6 visible: false
7
8- property string artist: ""
9+ property string artist: "Unknown Artist"
10 property var covers: []
11
12 CardView {

Subscribers

People subscribed via source and target branches