Merge lp:~vthompson/music-app/remix-hide-empty-items into lp:music-app/remix

[Victor Thompson]

Remove empty Albums and Artists

Remove empty Albums and Artists. This is a work around also currently employed for Genres. However, the genres fix is mostly legitimate, as genres can be empty--this change fixes various issues that lead to having blank metadata items as the first in the grid for Albums and Artists. This can happen, for instance, when an m3u file is scanned by mediascanner and included in the library reported by the app.

[Andrew Hayzen (ahayzen)]

LGTM may resolve a few of those bugs about clicking on empty items :)

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/music-app-remix-autolanding/46/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1155
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1155/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-utopic-amd64-autolanding/46

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:688
http://91.189.93.70:8080/job/music-app-remix-ci/141/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1162
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1162/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-utopic-amd64-ci/141

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/141/rebuild

review: Needs Fixing (continuous-integration)

[Andrew Hayzen (ahayzen)]

Shall we wait for bug 1384295 to be fixed before deciding to merge this?

review: Needs Information

[Victor Thompson (vthompson)]

Let's not hide empty items. Instead, let's display that the data is unknown [1]

[1] https://code.launchpad.net/~vthompson/music-app/remix-fix-1379452-2

review: Disapprove

Unmerged revisions

688. By Victor Thompson on 2014-10-22

Remove empty Album and Artist

=== modified file 'MusicAlbums.qml'
--- MusicAlbums.qml	2014-10-12 16:42:07 +0000
+++ MusicAlbums.qml	2014-10-22 04:04:25 +0000
@@ -37,6 +37,8 @@
                 id: albumsModel
                 store: musicStore
             }
+            filter.property: "title"
+            filter.pattern: /\S+/
             sort.property: "title"
             sort.order: Qt.AscendingOrder
         }

=== modified file 'MusicArtists.qml'
--- MusicArtists.qml	2014-10-14 15:46:07 +0000
+++ MusicArtists.qml	2014-10-22 04:04:25 +0000
@@ -39,10 +39,18 @@
     CardView {
         id: artistCardView
         itemWidth: units.gu(12)
-        model: ArtistsModel {
-            id: artistsModel
-            albumArtists: true
-            store: musicStore
+        model: SortFilterModel {
+            id: artistsModelFilter
+            property alias rowCount: artistsModel.rowCount
+            model: ArtistsModel {
+                id: artistsModel
+                albumArtists: true
+                store: musicStore
+            }
+            filter.property: "title"
+            filter.pattern: /\S+/
+            sort.property: "title"
+            sort.order: Qt.AscendingOrder
         }
         delegate: Card {
             id: artistCard