Merge lp:~vthompson/music-app/remix-header-sections into lp:music-app/remix

[Victor Thompson]

* Separate Now Playing and Queue views via header sections

This is a design proposal to clarify some of the confusion around the transitions to and from the Now Playing and Queue views.

[Victor Thompson (vthompson)]

#blocked on design

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:663
http://91.189.93.70:8080/job/music-app-remix-ci/69/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/873
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/873/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-utopic-amd64-ci/69

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/69/rebuild

review: Needs Fixing (continuous-integration)

[Victor Thompson (vthompson)]

The tests that switch views will need to be updated, but this is what the change looks like:

Now playing: http://i.imgur.com/ZGwYDoK.png
Queue: http://i.imgur.com/8BCAsJr.png

[Kill Animals (kill-animals)]

I think this looks great; Much better imho. Will test and see if it works with my latest mp

[Kill Animals (kill-animals)]

Rectangle will need to be resized.
http://i.imgur.com/7MMJneN.png

It would be nice to see an animation in this, but this can be done after this presumably gets merged.

Tested it with my branch; no conflicts, and worked nicely :)

review: Needs Fixing

[Victor Thompson (vthompson)]

This is being rejected. Design has come up with another way of fixing the current issue.

review: Disapprove

Unmerged revisions

663. By Victor Thompson on 2014-10-10

Design proposal for Now Playing/Queue confusion

=== modified file 'MusicNowPlaying.qml'
--- MusicNowPlaying.qml	2014-10-10 17:56:32 +0000
+++ MusicNowPlaying.qml	2014-10-10 22:41:20 +0000
@@ -49,15 +49,10 @@
     }
 
     head {
-        actions: [
-            Action {
-                objectName: "toggleView"
-                iconName: isListView ? "clear" : "media-playlist"
-                onTriggered: {
-                    isListView = !isListView
-                }
-            }
-        ]
+        sections {
+            model: [i18n.tr("Now playing"), i18n.tr("Queue")]
+            onSelectedIndexChanged: isListView = (head.sections.selectedIndex === 1)
+        }
     }
 
     Connections {

=== modified file 'music-app.qml'
--- music-app.qml	2014-10-09 02:17:21 +0000
+++ music-app.qml	2014-10-10 22:41:20 +0000
@@ -1103,7 +1103,7 @@
                     mainPageStack.push(nowPlaying);
                 }
 
-                nowPlaying.isListView = false;  // ensure full view
+                nowPlaying.head.sections.selectedIndex = 0;  // ensure Now Playing view (first index)
             }
 
             Component.onCompleted: musicToolbar.currentTab = selectedTab